Merge master into next.#669
Merged
Merged
Conversation
On 03e69e9, I updated the guards library to account for control flow graph splitting. However, the logic that relates SSA qualifiers for the guard and the guarded expression was not updated accordingly.
Just like syntax elements can be split in the control flow graph, so can SSA definitions. To make this clear, and to make debugging easier, this commit adds the splits as a prefix in the textual representation of SSA definitions.
CPP: Additional change notes (for 1.20)
…th leading underscore.
adityasharad
added
depends on internal PR
CPP: More tests of isSideEffectFree() / ExprHasNoEffect.ql
…d-alert-pos Java: Change alert location for ConstantLoopCondition.
…cations Approved by xiemaisi
Approved by esben-semmle
Query metadata style guide: add to ql/docs
Closed
C#: Fix a bug in `ThrowingCallable`
C#: Sync samples and qltest cases
Conflict in `cpp/ql/test/library-tests/sideEffects/functions/sideEffects.expected`, resolved by accepting test output (combining changes).
adityasharad
force-pushed
the
merge/master-next-111218
branch
from
60e1f05 to
f92456f
Compare
Collaborator
Author
|
@geoffw0 could you please check |
Contributor
It looks fine, it's just the changes from https://github.com/Semmle/ql/pull/641/files#diff-8b15d8396dfc1508c279afaf5b668802 |
|
LGTM, merging. |
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Release preparation for version 2.7.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No conflicts. Should be merged just before the corresponding internal PR.