perf: skip structural sharing on the notifications query - #3320
Draft
fmguerreiro wants to merge 1 commit into
Draft
fmguerreiro wants to merge 1 commit into
fmguerreiro wants to merge 1 commit into
Conversation
Marking a notification froze the renderer for 8.5s on a 1274-notification inbox: every cache write deep-compared the enriched tree.
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every write to the notifications query deep-compares the whole cached tree, so marking one notification walks every notification in the inbox, and each poll pays it again. This turns structural sharing off for that query.
Trade: each poll now returns fresh objects, so every mounted row re-renders. #3319 windows the list so only the visible rows exist.
Split out of #3319, as @setchy asked.