Skip to content

perf: skip structural sharing on the notifications query #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fmguerreiro wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Draft

perf: skip structural sharing on the notifications query #3320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/renderer/hooks/useNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ export const useNotifications = ({

placeholderData: keepPreviousData,

// Deep-walks every cached notification per write; dominates cost on large inboxes.
structuralSharing: false,

// Fresh for at least one poll cycle at the fastest possible interval, so
// data isn't treated as stale before a refetch could realistically have
// occurred. Uses the static floor rather than the live interval because
Expand Down
Loading