Skip to content

Fix the uploadimage form#1814

Closed
hcyuser wants to merge 2 commits into
hackmdio:developfrom
hcyuser:bugfix/uploadimage-form
Closed

Fix the uploadimage form#1814
hcyuser wants to merge 2 commits into
hackmdio:developfrom
hcyuser:bugfix/uploadimage-form

Conversation

@hcyuser

@hcyuser hcyuser commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@hcyuser hcyuser force-pushed the bugfix/uploadimage-form branch from d7553f6 to c20523a Compare August 9, 2023 13:12
@hcyuser hcyuser changed the title fix the uploadimage form Fix the uploadimage form Aug 9, 2023
@jackycute

jackycute commented Aug 10, 2023

Copy link
Copy Markdown
Member

Hi @hcyuser,

Thanks for contribution.
Can you explain what is this PR solving?

@hcyuser

hcyuser commented Aug 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

When I set up the image upload in local file system, I found I need to change path key into filepath to make it upload image successfully, which means the structure of files changed.

@jackycute jackycute closed this Aug 10, 2023
@jackycute jackycute reopened this Aug 10, 2023
@jackycute

jackycute commented Aug 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Oops, sorry for clicking wrong button.

@jackycute

jackycute commented Aug 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@hcyuser Can you describe the error message like paste the error text or screenshot?
I think this is caused by #1789 and was changed from node-formidable/formidable#689

jackycute
jackycute reviewed Aug 10, 2023
View reviewed changes
Comment thread lib/imageRouter/index.js Outdated
@hcyuser

hcyuser commented Aug 10, 2023

Copy link
Copy Markdown
Contributor Author

@hcyuser Can you describe the error message like paste the error text or screenshot?

I think this is caused by #1789 and was changed from node-formidable/formidable#689

I got Image path is missing or wrong on the terminal. After that, I found the structure of files changed, and therefore I modified it.

hcyuser added 2 commits August 10, 2023 21:25
@hcyuser
fix the uploadimage form
4b22a14 
Signed-off-by: hcyuser <user@hcy.idv.tw>
@hcyuser
add newline here to pass the standard lint.
3e1d5be 
Signed-off-by: hcyuser <user@hcy.idv.tw>
@hcyuser hcyuser force-pushed the bugfix/uploadimage-form branch from f031566 to 3e1d5be Compare August 10, 2023 13:25
@Yukaii

Yukaii commented Dec 26, 2023

Copy link
Copy Markdown
Member

closed in favor of #1836

@Yukaii Yukaii closed this Dec 26, 2023
@stanley2058 stanley2058 mentioned this pull request Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackycute jackycute jackycute left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hcyuser @jackycute @Yukaii