Safe default filename#689
Conversation
filename takes ext part, if filename returns extension it will not be duplicated anymore
feat: store newName
tunnckoCore
left a comment
tunnckoCore
left a comment
There was a problem hiding this comment.
Good job.
So now we only have filename and mime, right? Cool.
I'm more for calling it mimetype instead (plus it's same length as filename so.. haha), but you decide.
|
@illl48 @davidstrouk, @ololoepepe , @mclark-newvistas please try it out
|
tunnckoCore
left a comment
tunnckoCore
left a comment
There was a problem hiding this comment.
looks good i think, will review it again in the weekend.
|
Once this is merged we can open a PR for https://github.com/node-formidable/formidable/tree/filter-upload which helps to filter files before they are uploaded |
|
fixes #648 |
|
@tunnckoCore Can we merge it ? |
yep, i think so, sorry for not responding after the last review. ii think we are close to v2 after this, what you think? |
|
I agree |
2 participants
@tunnckoCore Changed a bit how filename works (read the commit messages to get an overview)
fixes #672, #671, #389, #596, #465, #358