fix: terminate output with a newline, drop the empty copyright line - #126
Open
BKPepe wants to merge 2 commits into
Open
fix: terminate output with a newline, drop the empty copyright line#126BKPepe wants to merge 2 commits into
BKPepe wants to merge 2 commits into
Conversation
Neither ended with one: --json wrote the marshalled bytes as-is and --csv explicitly trimmed the trailing newline. The shell prompt lands on the same line as the result, and --csv-header already ends with a newline, so the two CSV modes could not be concatenated into a valid file.
"librespeed.org Copyright (C)" has named no holder and no year since the first commit. It says nothing that the two lines above it do not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two output nits, one commit each.
--jsonand--csvend without a trailing newline —--jsonwrites themarshalled bytes as-is,
--csvexplicitly trims it. The shell prompt landson the same line as the result, and appending one
--csvrun to anotherglues the last field of the first into the first field of the second:
And
--versionprintslibrespeed.org Copyright (C)— no holder, no year,unchanged since the first commit.
After: exactly one
\non both.jqalready accepted the JSON; the changejust makes the output line-oriented like every other CLI.