Skip to content

fix: terminate output with a newline, drop the empty copyright line #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maddie merged 2 commits into from
Aug 11, 2026
Merged

fix: terminate output with a newline, drop the empty copyright line #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0fece
fix: terminate --json and --csv output with a newline
BKPepe Aug 9, 2026
c3e74e5
fix: drop the empty copyright line from --version
BKPepe Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion speedtest/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,13 +197,14 @@ func doSpeedTest(c *cli.Context, servers []defs.Server, telemetryServer defs.Tel
if err := gocsv.MarshalWithoutHeaders(&reps_csv, &buf); err != nil {
output.WriteError("Error generating CSV report: %s\n", err)
} else {
os.Stdout.WriteString(strings.TrimRight(buf.String(), "\n\r"))
os.Stdout.WriteString(strings.TrimRight(buf.String(), "\n\r") + "\n")
}
} else if c.Bool(defs.OptionJSON) {
if b, err := json.Marshal(&reps_json); err != nil {
output.WriteError("Error generating JSON report: %s\n", err)
} else {
os.Stdout.Write(b[:])
os.Stdout.WriteString("\n")
}
}

Expand Down
1 change: 0 additions & 1 deletion speedtest/speedtest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ func SpeedTest(c *cli.Context) error {
output.WriteOut("Licensed under GNU Lesser General Public License v3.0\n")
output.WriteOut("LibreSpeed\tCopyright (C) 2016-2020 Federico Dossena\n")
output.WriteOut("librespeed-cli\tCopyright (C) 2020 Maddie Zhan\n")
output.WriteOut("librespeed.org\tCopyright (C)\n")
return nil
}

Expand Down