Move fs operations into the destroy method#692
Merged
Conversation
Contributor
Author
|
Hmm not sure why this is failing lint rules - they seem unrelated to this PR |
GrosSacASac
approved these changes
Mar 3, 2021
Contributor
|
Thanks |
Contributor
Author
|
No problem! Let me know if these tests / lint rules are failing due to this PR and if there's anything else I can do. |
Contributor
|
The failing test are because I rushed the conversion to jest |
Contributor
Author
|
ok cool, ty! |
Contributor
|
If you have time try to test #689 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the uncaught exception thrown for
VolatileFiles(re: file streams) when the connection is aborted.This is the proper location to be doing fs operations, since VolatileFile has no fs presence, while PersistentFile does. I also removed the
setTimeoutcall becausefs.unlinkis already an async operation.I am curious though if we should propagate an error from
fs.unlinkor not.Fixes #691