Revert "fs: fix close listener leak in FileHandle streams"

[MikeMcC399]

Refs: #64227
Refs: #64214

This reverts commit 8488e13.

@ronag wrote in #64227 (comment)

This is broken and should be reverted. Will unref the handle multiple times.

cc: @Y1D7NG @davidje13

[github-actions]

Fast-track has been requested by @ovflowd. Please 👍 to approve.

[ovflowd]

Removed need of CI, since we're reverting to previous code, this is known to be stable. Added fast-track.

[ronag]

Proper fix is to use eos/finished instead of 'close' listener

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75970/

[panva]

Removed need of CI, since we're reverting to previous code, this is known to be stable. Added fast-track.

The needs-ci label doesn't drive the need for CI. Removing it does absolutely nothing. CI is needed even for a revert, especially since other commits landed since that mean the codebase is not returning to a known state.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (cf30b2e) to head (5f3e792).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65387      +/-   ##
==========================================
+ Coverage   90.11%   90.12%   +0.01%     
==========================================
  Files         752      752              
  Lines      251861   251849      -12     
  Branches    47365    47363       -2     
==========================================
+ Hits       226955   226984      +29     
+ Misses      16238    16192      -46     
- Partials     8668     8673       +5     

Files with missing lines	Coverage Δ
lib/internal/fs/streams.js	93.10% <100.00%> (-0.14%)	⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75979/

[nodejs-github-bot]

Landed in 882a781

[aduh95]

Please remember to add the dont-land labels to avoid the polluting the changelogs (too late for Node.js 26 atp, it already landed there)

[MikeMcC399]

Please remember to add the dont-land labels to avoid the polluting the changelogs (too late for Node.js 26 atp, it already landed there)

This should probably be added as an instruction to the Collaborator guide > Reverting commits section.

Edit: PR #65848 proposed to document this.