doc: expand revert commit collaborator instructions - #65848
Open
MikeMcC399 wants to merge 1 commit into
Open
Conversation
Advise to add dont-land labels to commit and revert commit pairs to prevent redundant backporting. Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Collaborator
|
Review requested:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #65387 (comment)
Situation
Instructions in the Collaborator guide > Reverting commits documentation section do not mention about any need to apply
dont-landlabels.If a revert PR is targeting the
mainbranch and the original commit has not been backported to any release line, then backporting would lead to a redundant pair of commit / revert commits in a release line.Change
Add instructions to the Collaborator guide > Reverting commits documentation section to apply
dont-landlabels when appropriate.