This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): warn to provide a key for useFetch with transform option - #4590
Merged
Conversation
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
|
I think we can exclude options that are not related to fetch like transform from hash transformation. hashing it to distinguish by request. |
atinux
reviewed
Apr 26, 2022
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Member
Author
I would say that transform should make a difference to the hash. Consider: await useFetch('/api/test', { transform: data => data[0] })
await useFetch('/api/test')These two calls will result in different data, and if we don't enforce a key generation then there's a danger of mismatching payloads. |
Member
|
Okay i'm fine with adding warning until find a better way for auto hashing. Can we in the meantime remove |
useFetch with transform option
useFetch with transform optionuseFetch with transform option
pi0
approved these changes
Apr 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#13790
❓ Type of change
📚 Description
This PR addresses two issues:
.toString()differs between server/client so the generated key (fromohash) doesn't match.Other options:
It feels like the safest option is to require a user to provide a custom key in the event of using
transform.📝 Checklist