Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): warn to provide a key for useFetch with transform option #4590

Merged
pi0 merged 5 commits into from
Apr 27, 2022
Merged

fix(nuxt): warn to provide a key for useFetch with transform option #4590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e65c450
fix(nuxt): require users to provide a key for useFetch + transform
danielroe Apr 25, 2022
ab6a93e
fix: refresh data if it's not in payload
danielroe Apr 25, 2022
26cac25
Update packages/nuxt/src/app/composables/fetch.ts
danielroe Apr 26, 2022
ac499f4
fix: remove transform from hash calculation
danielroe Apr 27, 2022
cdd83a5
Merge remote-tracking branch 'origin/main' into fix/key-transform
danielroe Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nuxt/src/app/composables/asyncData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export function useAsyncData<

// Client side
if (process.client) {
if (fetchOnServer && nuxt.isHydrating) {
if (fetchOnServer && nuxt.isHydrating && key in nuxt.payload.data) {
// 1. Hydration (server: true): no fetch
asyncData.pending.value = false
} else if (instance && (nuxt.isHydrating || options.lazy)) {
Expand Down
5 changes: 4 additions & 1 deletion packages/nuxt/src/app/composables/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ export function useFetch<
request: Ref<ReqT> | ReqT | (() => ReqT),
opts: UseFetchOptions<_ResT, Transform, PickKeys> = {}
) {
const key = '$f_' + (opts.key || hash([request, opts]))
if (process.dev && opts.transform && !opts.key) {
console.warn('[nuxt] You should provide a key for `useFetch` when using a custom transform function.')
}
const key = '$f_' + (opts.key || hash([request, { ...opts, transform: null }]))
const _request = computed<FetchRequest>(() => {
let r = request
if (typeof r === 'function') {
Expand Down