docs: clarify view aggregation precedence#5342
Open
naveenvenk17 wants to merge 1 commit into
Open
Conversation
aabmass
approved these changes
Jun 22, 2026
| When a view matches an instrument, a non-`DefaultAggregation` | ||
| aggregation configured on the view takes precedence over the | ||
| `MetricReader` preferred aggregation for that instrument class. If | ||
| the view leaves aggregation as `DefaultAggregation`, the |
Member
There was a problem hiding this comment.
This second sentence feels like an implementation detail we can leave out of documentation for now, unless that behavior is explicitly in the spec. Do you mind double checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Viewaggregation interacts withMetricReaderpreferred aggregation.DefaultAggregationview aggregation takes precedence, whileDefaultAggregationlets the reader preferred aggregation apply.Validation
git diff --checkpython -m compileall opentelemetry-sdk\src\opentelemetry\sdk\metrics\_internal\view.pyCloses #2834.