Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ class View:
aggregation instance to use when data is aggregated for the
corresponding metrics stream. If `None` an instance of
`DefaultAggregation` will be used.
When a view matches an instrument, a non-`DefaultAggregation`
aggregation configured on the view takes precedence over the
`MetricReader` preferred aggregation for that instrument class. If
the view leaves aggregation as `DefaultAggregation`, the

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This second sentence feels like an implementation detail we can leave out of documentation for now, unless that behavior is explicitly in the spec. Do you mind double checking

`MetricReader` preferred aggregation is used.

exemplar_reservoir_factory: This is a metric stream customizing attribute:
the exemplar reservoir factory
Expand Down
Loading