Skip to content

USHIFT-1402: remove error trap from rebase to avoid interfering with command output - #2005

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
dhellmann:USHIFT-1402-change-trap-in-rebase-script
Jul 6, 2023
Merged

USHIFT-1402: remove error trap from rebase to avoid interfering with command output#2005
openshift-merge-robot merged 1 commit into
openshift:mainfrom
dhellmann:USHIFT-1402-change-trap-in-rebase-script

Conversation

@dhellmann

@dhellmann dhellmann commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

/assign @pmtk

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 6, 2023
@openshift-ci-robot

openshift-ci-robot commented Jul 6, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@dhellmann: This pull request references USHIFT-1402 which is a valid jira issue.

Details

In response to this:

/assign @pmtk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
openshift-ci Bot requested review from jerpeter1 and pmtk July 6, 2023 15:30
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@dhellmann
USHIFT-1402: remove error reporting trap from rebase script
d093d07 
Reporting errors using trap means that pipelines that acceptably
produce no output, such as a grep that finds no results, instead
produce the error message.
@dhellmann
dhellmann force-pushed the USHIFT-1402-change-trap-in-rebase-script branch from b5cb9bf to d093d07 Compare July 6, 2023 15:45
@pmtk

pmtk commented Jul 6, 2023

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@dhellmann dhellmann changed the title USHIFT-1402: report error from rebase without interfering with command output USHIFT-1402: remove error trap rebase to avoid interfering with command output Jul 6, 2023
@dhellmann dhellmann changed the title USHIFT-1402: remove error trap rebase to avoid interfering with command output USHIFT-1402: remove error trap from rebase to avoid interfering with command output Jul 6, 2023
@dhellmann dhellmann mentioned this pull request Jul 6, 2023
Closed
@openshift-merge-robot
openshift-merge-robot merged commit 0ba2d5c into openshift:main Jul 6, 2023
@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@dhellmann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-e2e-arm d093d07 link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1
@pmtk pmtk Awaiting requested review from pmtk

Assignees

@pmtk pmtk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhellmann @openshift-ci-robot @pmtk @openshift-merge-robot