manual rebase 2023-07-06 - #2006
Conversation
Reporting errors using trap means that pipelines that acceptably produce no output, such as a grep that finds no results, instead produce the error message.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
The first commit in this series is part of #2005 and we should merge that separately, then squash the commits in this PR when it merges. |
dhellmann
added
the
tide/merge-method-squash
|
@copejon I think your comment #2003 (comment) applies here, too. Can you look at whatever we need to change in the rebase script to make that happen? Perhaps we should not merge this PR at all? |
| @@ -0,0 +1,14 @@ | |||
| kind: Role | |||
There was a problem hiding this comment.
Leader election is disabled on the csi snapshotter. This being a manual rebase, let's go ahead and drop these (role / binding). I'm looking at the script now to see what's causing them to populate, but they shouldn't be included.
Looking at it now. Shouldn't be a huge issue. I'll have a PR up in a bit to fix it, then we can retry the rebase. |
|
@dhellmann: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close obsoleted by #2008 |
|
@dhellmann: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
No description provided.