[NO-ISSUE] LVMS snapshot rbac fix - #2007
Merged
openshift-merge-robot merged 4 commits intoJul 6, 2023
Merged
Conversation
Signed-off-by: Jon Cope <jcope@redhat.com>
Signed-off-by: Jon Cope <jcope@redhat.com>
openshift-ci
Bot
added
the
approved
Signed-off-by: Jon Cope <jcope@redhat.com>
copejon
force-pushed
the
csi-snapshot-rebase-fix
branch
from
July 6, 2023 19:07
be57b97 to
59cb229
Compare
copejon
commented
Jul 6, 2023
| - update | ||
| - patch | ||
| - delete | ||
| - apiGroups: |
Contributor
Author
There was a problem hiding this comment.
This deleted section is now defined separately in the additional clusterrole/binding
Contributor
Author
|
/assign @pmtk |
… keep the 05_operand_rbac.yaml file Signed-off-by: Jon Cope <jcope@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, dhellmann The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rebase ops should pull topolvm's rbac definitions during the rebase.