Skip to content

Rebase 4.14.0 0.nightly 2023 07 05 191022 amd64 2023 07 05 arm64 2023 07 05 - #2008

Closed
dhellmann wants to merge 13 commits into
openshift:mainfrom
dhellmann:rebase-4.14.0-0.nightly-2023-07-05-191022_amd64-2023-07-05_arm64-2023-07-05
Closed

Rebase 4.14.0 0.nightly 2023 07 05 191022 amd64 2023 07 05 arm64 2023 07 05#2008
dhellmann wants to merge 13 commits into
openshift:mainfrom
dhellmann:rebase-4.14.0-0.nightly-2023-07-05-191022_amd64-2023-07-05_arm64-2023-07-05

Conversation

@dhellmann

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci
openshift-ci Bot requested review from ggiguash and pliurh July 6, 2023 19:40
@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@dhellmann
dhellmann force-pushed the rebase-4.14.0-0.nightly-2023-07-05-191022_amd64-2023-07-05_arm64-2023-07-05 branch from c631595 to 15ead8b Compare July 6, 2023 19:45
@dhellmann

Copy link
Copy Markdown
Contributor Author

/hold

The route changes look right. @copejon, please take a look at the CSI parts. Then we can approve #2007 and submit a clean version of this PR.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023
@copejon

copejon commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@dhellmann The CSI changes lgtm.

@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@dhellmann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 15ead8b link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann

Copy link
Copy Markdown
Contributor Author

/close

obsoleted by #2012

@openshift-ci openshift-ci Bot closed this Jul 7, 2023
@openshift-ci

openshift-ci Bot commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

@dhellmann: Closed this PR.

Details

In response to this:

/close

obsoleted by #2012

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants