OCPBUGS-99298: increase catalog HTTP client timeout from 10s to 5m#768
Conversation
…t from 10s to 5m The 10-second timeout was too aggressive for large catalog responses. Increase it to 5 minutes to avoid timeouts when fetching catalogs. Signed-off-by: Todd Short <tshort@redhat.com>
|
@tmshort: This pull request references Jira Issue OCPBUGS-99298, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/jira refresh |
|
@tmshort: This pull request references Jira Issue OCPBUGS-99298, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
|
@tmshort: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-upgrade-ovn-single-node |
|
/retest |
|
/test e2e-aws-upgrade-ovn-single-node |
|
/label backport-risk-assessed |
|
/retest |
|
/test e2e-aws-techpreview-olmv1-ext |
|
/test openshift-e2e-aws |
|
/test e2e-aws-techpreview-olmv1-ext |
|
/retest |
7 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
Backport of upstream #2674. In HA topology (replicas=2), the old catalogd serverutil used OnlyServeWhenLeader=true: the non-leader pod bound the TCP port via net.Listen so the OS accepted connections, but no HTTP server was running. Operator-controller hit the non-leader ~50% of the time and the connection hung silently. With the HTTP client timeout raised to 5m (OCPBUGS-92037), this hang lasted the full 5 minutes instead of 10s, causing catalog caches to never be populated within test windows. Fix: - catalogd serverutil: switch to NeedLeaderElection=false so all pods serve HTTP; non-leaders return 404 (empty local cache) instead of hanging. Register a readiness check so the pod is excluded from endpoints until the server is ready. - client.go: do not cache non-200 responses; return the error directly so the next reconcile retries a fresh HTTP request and eventually hits the leader. Upstream: operator-framework/operator-controller#2674 Signed-off-by: Todd Short <tshort@redhat.com>
|
It appears that an HA commit was missed in prior backports, and this backport is dependent on it. |
|
/test openshift-e2e-aws This test failure is now different, no OLM errors, so retrying. |
|
@tmshort: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
@tmshort: This pull request references Jira Issue OCPBUGS-99298, which is valid. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @grokspawn |
|
@grokspawn: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f4afcda
into
openshift:release-4.22
|
@tmshort: Jira Issue Verification Checks: Jira Issue OCPBUGS-99298 Jira Issue OCPBUGS-99298 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
|
@tmshort: new pull request created: #773 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fix included in release 4.22.0-0.nightly-2026-07-26-162351 |
The 10-second timeout was too aggressive for large catalog responses. Increase it to 5 minutes to avoid timeouts when fetching catalogs.
Also needed to backport "Fix catalogd HA readiness and non-200 cache handling", which the original fix was dependent on.