[release-4.21] OCPBUGS-99756: increase catalog HTTP client timeout from 10s to 5m by openshift-cherrypick-robot · Pull Request #773 · openshift/operator-framework-operator-controller

openshift-cherrypick-robot · 2026-07-24T20:01:29Z

This is an automated cherry-pick of #768

/assign tmshort

…t from 10s to 5m The 10-second timeout was too aggressive for large catalog responses. Increase it to 5 minutes to avoid timeouts when fetching catalogs. Signed-off-by: Todd Short <tshort@redhat.com>

Backport of upstream #2674. In HA topology (replicas=2), the old catalogd serverutil used OnlyServeWhenLeader=true: the non-leader pod bound the TCP port via net.Listen so the OS accepted connections, but no HTTP server was running. Operator-controller hit the non-leader ~50% of the time and the connection hung silently. With the HTTP client timeout raised to 5m (OCPBUGS-92037), this hang lasted the full 5 minutes instead of 10s, causing catalog caches to never be populated within test windows. Fix: - catalogd serverutil: switch to NeedLeaderElection=false so all pods serve HTTP; non-leaders return 404 (empty local cache) instead of hanging. Register a readiness check so the pod is excluded from endpoints until the server is ready. - client.go: do not cache non-200 responses; return the error directly so the next reconcile retries a fresh HTTP request and eventually hits the leader. Upstream: operator-framework/operator-controller#2674 Signed-off-by: Todd Short <tshort@redhat.com>

coderabbitai · 2026-07-24T20:01:42Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a36e8dfc-5697-46a7-ac35-5d0dd27d24e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

tmshort · 2026-07-24T20:02:29Z

/approve

openshift-ci-robot · 2026-07-24T20:02:43Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-99298 has been cloned as Jira Issue OCPBUGS-99756. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-99756: increase catalog HTTP client timeout from 10s to 5m

Details

In response to this:

This is an automated cherry-pick of #768

/assign tmshort

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-07-24T20:02:58Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-99756, which is invalid:

expected dependent Jira Issue OCPBUGS-99298 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
expected dependent Jira Issue OCPBUGS-99298 to target a version in 4.22.0, but it targets "4.22.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #768

/assign tmshort

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rashmigottipati

/lgtm
/approve

openshift-ci · 2026-07-24T20:07:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tmshort · 2026-07-24T20:15:40Z

/jira refresh

openshift-ci-robot · 2026-07-24T20:15:45Z

@tmshort: This pull request references Jira Issue OCPBUGS-99756, which is invalid:

expected dependent Jira Issue OCPBUGS-99298 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-24T23:06:44Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tmshort · 2026-07-25T12:20:43Z

/jira refresh

openshift-ci-robot · 2026-07-25T12:20:48Z

@tmshort: This pull request references Jira Issue OCPBUGS-99756, which is invalid:

expected dependent Jira Issue OCPBUGS-99298 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort · 2026-07-25T20:26:34Z

/jira refresh

openshift-ci-robot · 2026-07-25T20:26:38Z

@tmshort: This pull request references Jira Issue OCPBUGS-99756, which is invalid:

expected dependent Jira Issue OCPBUGS-99298 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tmshort added 2 commits July 24, 2026 20:01

UPSTREAM: <carry>: OCPBUGS-99298: increase catalog HTTP client timeou…

4a055f1

…t from 10s to 5m The 10-second timeout was too aggressive for large catalog responses. Increase it to 5 minutes to avoid timeouts when fetching catalogs. Signed-off-by: Todd Short <tshort@redhat.com>

openshift-cherrypick-robot assigned tmshort Jul 24, 2026

openshift-cherrypick-robot mentioned this pull request Jul 24, 2026

OCPBUGS-99298: increase catalog HTTP client timeout from 10s to 5m #768

Merged

openshift-ci Bot requested review from perdasilva and tmshort July 24, 2026 20:01

openshift-ci Bot changed the title ~~[release-4.21] OCPBUGS-99298: increase catalog HTTP client timeout from 10s to 5m~~ [release-4.21] OCPBUGS-99756: increase catalog HTTP client timeout from 10s to 5m Jul 24, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2026

rashmigottipati approved these changes Jul 24, 2026

View reviewed changes

openshift-ci Bot assigned rashmigottipati Jul 24, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026

Uh oh!

Conversation

openshift-cherrypick-robot commented Jul 24, 2026

Uh oh!

coderabbitai Bot commented Jul 24, 2026

Review skipped

Uh oh!

tmshort commented Jul 24, 2026

Uh oh!

openshift-ci-robot commented Jul 24, 2026

Uh oh!

openshift-ci-robot commented Jul 24, 2026

Uh oh!

rashmigottipati left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

tmshort commented Jul 24, 2026

Uh oh!

openshift-ci-robot commented Jul 24, 2026

Uh oh!

openshift-ci Bot commented Jul 24, 2026

Uh oh!

tmshort commented Jul 25, 2026

Uh oh!

openshift-ci-robot commented Jul 25, 2026

Uh oh!

tmshort commented Jul 25, 2026

Uh oh!

openshift-ci-robot commented Jul 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants