Skip to content

Enhancement: Build documentation on GitHub Actions - #2

Closed
localheinz wants to merge 1 commit into
php:masterfrom
localheinz:feature/github-actions
Closed

localheinz wants to merge 1 commit into
php:masterfrom
localheinz:feature/github-actions

Conversation

@localheinz

@localheinz localheinz commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

This PR

  • builds the documentation on GitHub Actions

💁‍♂️ The workflow is identical to the one proposed in php/doc-en#299 (except for the LANGUAGE environment variable). You can see this in action at localheinz#1.

@localheinz
localheinz force-pushed the feature/github-actions branch from a59fbbf to 43726d3 Compare December 30, 2020 22:33
@cmb69

cmb69 commented Dec 30, 2020

Copy link
Copy Markdown
Member

Thanks for the PR! Very nice!

You have to clone php/doc-en as well, so you end up with:

de/
doc-base/
en/

Missing files in de are just reused from en.

@localheinz
localheinz force-pushed the feature/github-actions branch from 43726d3 to e339d2f Compare December 31, 2020 04:20
@localheinz

Copy link
Copy Markdown
Contributor Author

Thank you, @cmb69 - I adjusted the job accordingly!

@localheinz
localheinz marked this pull request as ready for review December 31, 2020 08:47
@localheinz
localheinz force-pushed the feature/github-actions branch from e339d2f to 62710ca Compare December 31, 2020 08:48
Comment thread .github/workflows/integrate.yaml Outdated
@localheinz
localheinz force-pushed the feature/github-actions branch 13 times, most recently from 2d646c3 to 30aec52 Compare December 31, 2020 17:23
@localheinz
localheinz force-pushed the feature/github-actions branch 3 times, most recently from 802b716 to 1cab503 Compare January 8, 2021 17:06
@localheinz

Copy link
Copy Markdown
Contributor Author

Anything missing here?

@cmb69

cmb69 commented Jan 24, 2021

Copy link
Copy Markdown
Member

Anything missing here?

Yes, the reminder that this PR should be merged. Sorry, complete forgot about it.

@php-pulls php-pulls closed this in a301fcb Jan 24, 2021
@localheinz

Copy link
Copy Markdown
Contributor Author

Thank you, @cmb69!

brcontainer added a commit to brcontainer/doc-de that referenced this pull request Sep 8, 2026
Same as: php/doc-en#5842

Incorrect:

```php
case 0x8000: // regular
    $info = 'r';
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants