Skip to content

Enhancement: Switch from Travis CI to GitHub Actions - #299

Closed
localheinz wants to merge 1 commit into
php:masterfrom
localheinz:feature/github-actions
Closed

localheinz wants to merge 1 commit into
php:masterfrom
localheinz:feature/github-actions

Conversation

@localheinz

@localheinz localheinz commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

This PR

  • switches from Travis CI to GitHub Actions

💁‍♂️ You can see this in action at localheinz#1.

@localheinz
localheinz force-pushed the feature/github-actions branch from 172ccc2 to 76a20b0 Compare December 30, 2020 22:02
Comment thread .github/workflows/integrate.yaml Outdated
@localheinz
localheinz force-pushed the feature/github-actions branch from 76a20b0 to 757125c Compare December 30, 2020 22:05
Comment thread .github/workflows/integrate.yaml
@localheinz
localheinz force-pushed the feature/github-actions branch 3 times, most recently from 7e936ee to bfd8666 Compare December 30, 2020 22:11
Comment thread .github/workflows/integrate.yaml Outdated
@localheinz
localheinz marked this pull request as ready for review December 30, 2020 22:14
Comment thread .github/workflows/integrate.yaml
Comment thread .github/workflows/integrate.yaml
Comment thread .github/workflows/integrate.yaml Outdated
@localheinz
localheinz force-pushed the feature/github-actions branch 3 times, most recently from c165972 to a18395d Compare December 30, 2020 22:33
@localheinz
localheinz marked this pull request as ready for review December 30, 2020 22:34
Comment thread .github/workflows/integrate.yaml Outdated
nikic
nikic previously requested changes Dec 30, 2020

@nikic nikic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we can't use GH actions right now, as we need someone to verify the @php-pulls email address. Marking as changes requested until we can get that done.

@localheinz
localheinz force-pushed the feature/github-actions branch from a18395d to 9d411da Compare December 30, 2020 22:51
@nikic
nikic dismissed their stale review December 31, 2020 15:49

GH Actions is now usable in the PHP organization

@localheinz
localheinz force-pushed the feature/github-actions branch 8 times, most recently from 3bf56ea to a4e7363 Compare December 31, 2020 17:21
@localheinz
localheinz force-pushed the feature/github-actions branch from a4e7363 to 4e5ac5b Compare December 31, 2020 17:24
@localheinz

Copy link
Copy Markdown
Contributor Author

@nikic

Thank you for the update!

@localheinz
localheinz force-pushed the feature/github-actions branch 3 times, most recently from 22bad5e to 012bb61 Compare January 6, 2021 11:45
Comment thread .github/workflows/integrate.yaml
@localheinz
localheinz force-pushed the feature/github-actions branch 6 times, most recently from 38f09b8 to ae90fa5 Compare January 8, 2021 17:00
@cmb69

cmb69 commented Jan 8, 2021

Copy link
Copy Markdown
Member

[…], as we need someone to verify the @php-pulls email address.

Who could do that?

@nikic

nikic commented Jan 8, 2021

Copy link
Copy Markdown
Member

@cmb69 This is already done, so it's fine to merge.

@localheinz
localheinz force-pushed the feature/github-actions branch from ae90fa5 to d382e30 Compare January 8, 2021 17:08
@localheinz

Copy link
Copy Markdown
Contributor Author

Quick heads-up, the workflow is exactly the same as the one in php/doc-de#2, with one slight difference:

--- doc-de/.github/workflows/integrate.yaml	2021-01-08 18:06:49.000000000 +0100
+++ doc-en/.github/workflows/integrate.yaml	2021-01-08 18:08:30.000000000 +0100
@@ -17,7 +17,7 @@
     strategy:
       matrix:
         language:
-          - "de"
+          - "en"

     steps:
       - name: "Checkout php/doc-${{ matrix.language }}"

The idea is to use workflows with the least differences across all repositories.

Instead of using a matrix, we could also parse the language identifier from the repository name, if that makes sense.

name: "Integrate"

on:
pull_request: null

@localheinz localheinz Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afilina

Quick note on why I use

on:
  pull_request: null

here: I use yamllint in my repositories to lint YAML files, and the configuration I use complains when leaving it empty.

For an example, see https://github.com/ergebnis/php-library-template/blob/f6af5cb5c234a146f620061e95b34b432bf2e1c8/.github/workflows/integrate.yaml#L32-L37.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying :)

@cmb69

cmb69 commented Jan 8, 2021

Copy link
Copy Markdown
Member

The idea is to use workflows with the least differences across all repositories.

That makes sense.

Instead of using a matrix, we could also parse the language identifier from the repository name, if that makes sense.

I think it's good as is.

Is this ready to be merged, @localheinz ?

@localheinz

Copy link
Copy Markdown
Contributor Author

@cmb69

👍

@cmb69

cmb69 commented Jan 8, 2021

Copy link
Copy Markdown
Member

Thank you, @localheinz !

@php-pulls php-pulls closed this in 9b20566 Jan 8, 2021
@localheinz

Copy link
Copy Markdown
Contributor Author

Thank you, @cmb69!

@localheinz
localheinz deleted the feature/github-actions branch January 8, 2021 18:21
@localheinz

Copy link
Copy Markdown
Contributor Author

@cmb69

Is there interest in adding more tooling to the workflows?

@cmb69

cmb69 commented Jan 8, 2021

Copy link
Copy Markdown
Member

Well, it might be nice to actually build the documentation for pull request, so it could be viewed, but I have doubts that that's reasonably doable. Other than that, running ./configure as it's done now, is probably all we need. :)

@localheinz

Copy link
Copy Markdown
Contributor Author

@cmb69

That sounds quite cool, actually, and should be possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants