Enhancement: Switch from Travis CI to GitHub Actions - #299
localheinz wants to merge 1 commit into
Conversation
172ccc2 to
76a20b0
Compare
76a20b0 to
757125c
Compare
7e936ee to
bfd8666
Compare
c165972 to
a18395d
Compare
nikic
left a comment
There was a problem hiding this comment.
Turns out we can't use GH actions right now, as we need someone to verify the @php-pulls email address. Marking as changes requested until we can get that done.
a18395d to
9d411da
Compare
GH Actions is now usable in the PHP organization
3bf56ea to
a4e7363
Compare
a4e7363 to
4e5ac5b
Compare
|
Thank you for the update! |
22bad5e to
012bb61
Compare
38f09b8 to
ae90fa5
Compare
Who could do that? |
|
@cmb69 This is already done, so it's fine to merge. |
ae90fa5 to
d382e30
Compare
|
Quick heads-up, the workflow is exactly the same as the one in php/doc-de#2, with one slight difference: --- doc-de/.github/workflows/integrate.yaml 2021-01-08 18:06:49.000000000 +0100
+++ doc-en/.github/workflows/integrate.yaml 2021-01-08 18:08:30.000000000 +0100
@@ -17,7 +17,7 @@
strategy:
matrix:
language:
- - "de"
+ - "en"
steps:
- name: "Checkout php/doc-${{ matrix.language }}"The idea is to use workflows with the least differences across all repositories. Instead of using a matrix, we could also parse the language identifier from the repository name, if that makes sense. |
| name: "Integrate" | ||
|
|
||
| on: | ||
| pull_request: null |
There was a problem hiding this comment.
Quick note on why I use
on:
pull_request: nullhere: I use yamllint in my repositories to lint YAML files, and the configuration I use complains when leaving it empty.
For an example, see https://github.com/ergebnis/php-library-template/blob/f6af5cb5c234a146f620061e95b34b432bf2e1c8/.github/workflows/integrate.yaml#L32-L37.
That makes sense.
I think it's good as is. Is this ready to be merged, @localheinz ? |
|
👍 |
|
Thank you, @localheinz ! |
|
Thank you, @cmb69! |
|
Is there interest in adding more tooling to the workflows? |
|
Well, it might be nice to actually build the documentation for pull request, so it could be viewed, but I have doubts that that's reasonably doable. Other than that, running ./configure as it's done now, is probably all we need. :) |
|
That sounds quite cool, actually, and should be possible! |
This PR
💁♂️ You can see this in action at localheinz#1.