Improve StrSplit returnType - #3999
Merged
Merged
Conversation
VincentLanglet
force-pushed
the
strSplit
branch
2 times, most recently
from
May 18, 2025 20:12
fff96fc to
8764aad
Compare
Contributor
Author
|
If it's ok, I opened #4000 first |
VincentLanglet
force-pushed
the
strSplit
branch
12 times, most recently
from
June 13, 2025 00:27
c4c4d18 to
14649b5
Compare
VincentLanglet
marked this pull request as ready for review
June 13, 2025 00:40
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
commented
Jun 13, 2025
| foreach ($constantStrings as $constantString) { | ||
| $value = $constantString->getValue(); | ||
|
|
||
| if ($encoding === null && $value === '') { |
Contributor
Author
There was a problem hiding this comment.
This logic exists to avoid the same issue than phpstan/phpstan#13129
ondrejmirtes
requested changes
Jul 17, 2025
ondrejmirtes
left a comment
ondrejmirtes
left a comment
Member
There was a problem hiding this comment.
This one could also be only for 2.1.x.
VincentLanglet
force-pushed
the
strSplit
branch
2 times, most recently
from
July 17, 2025 16:43
12956d2 to
0e64b28
Compare
VincentLanglet
force-pushed
the
strSplit
branch
2 times, most recently
from
July 17, 2025 17:36
2aeca20 to
80ab977
Compare
Contributor
Author
|
@ondrejmirtes The HasPropertyTypeTest::testIsSuperTypeOf with data set #4 seems random, So I don't think, it's related to the PR ; this is now ready. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @herndlm
I saw you worked multiple times on this extension with
str_split/mb_str_splitstring arg compound types + default return type formb_str_split#1496str_splitreturns an empty array since PHP 8.2 #1544