Migrate legacy tests to NodeScopeResolverTest - #4000
Merged
Conversation
VincentLanglet
force-pushed
the
legacyStrSplit
branch
from
May 18, 2025 21:09
1d2d5b7 to
81415b9
Compare
VincentLanglet
force-pushed
the
legacyStrSplit
branch
from
May 18, 2025 21:20
81415b9 to
53578cb
Compare
VincentLanglet
marked this pull request as ready for review
May 18, 2025 21:26
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
Author
|
Also if wanted/useful @ondrejmirtes I could migrate more legacy test to NodeScopeResolverTest in others PR. |
Member
|
Thank you very much! Yes, please send more PRs making this class smaller 😊 It's legacy after all. |
Member
|
Please submit more PRs on top of 2.1.x, there are many changes to tests there. |
Contributor
Author
Sorry, it was needed for #3999 (but maybe I should have open the str_split pr on 2.1.x, I never know which one I should chose). I'll try to migrate more tests on 2.1.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help writing/updating tests for #3999