fix(web): keep numbered jumps from stealing browser tabs

[Yash-Singh1]

What Changed

Default mod+1 through mod+9 thread jumps and model-picker jumps now use when: !isWeb, so a browser tab keeps Cmd/Ctrl+number for switching tabs. Desktop still jumps threads, and still jumps models while the picker is open.

Shortcut matching now has an isWeb context key (true in a browser, false in Electron). Chat, pull requests, and Settings all pass it. User docs explain the key and how to drop !isWeb if you want the jumps in a browser.

Inside an already expanded activity group, thought traces render under the Thought header with no second disclosure.

Why

In the web app, the default numbered jumps took the same chords the browser uses to switch tabs. Users hitting Cmd/Ctrl+1–9 expected a tab change and got a thread or model jump instead. Gating those defaults on !isWeb leaves desktop behavior alone and lets people re-enable the jumps in Settings if they want them in a browser.

Thought text in an expanded activity row was already one click in. A nested Thought toggle hid that text behind another click.

UI Changes

Holding Cmd/Ctrl in a browser no longer shows thread jump hints on 1–9. Desktop is unchanged. Expanding an activity row with thoughts shows the thought body immediately, with no chevron on the Thought header.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

Summary by CodeRabbit

• New Features

  • Added isWeb and isDesktop conditions for customizing keyboard shortcuts by environment.
  • Thread and model-picker jump shortcuts now run only in the desktop app, preventing conflicts with browser tab-switching shortcuts.

• Documentation

  • Documented both environment conditions and explained how to enable thread or model jumps in browser settings.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+36 B (+0.3%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	0 B (0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.5 KiB	+36 B (+0.5%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.2 KiB	56.3 KiB	+44 B (+0.1%)	66.4 KiB	✅
Codex	Live turn messages	9	10	+1 (+11.1%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+17 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	−4 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.5 KiB	+21 B (+0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: 1455cb5 · PR result: 95c7a8f · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR changes the shared default keybindings so numbered jumps are disabled by default in browser tabs, while adding corresponding runtime context and settings support. The scope is focused and tested, but changing product defaults requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: dd56cc6e-44c2-40a2-b5bb-a41b046909f6

📥 Commits

Reviewing files that changed from the base of the PR and between be0fa96 and 95c7a8f.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (9)

• apps/web/src/components/ChatView.tsx
• apps/web/src/components/pullRequest/PullRequestDetailPanel.test.tsx
• apps/web/src/components/settings/KeybindingsSettings.logic.test.ts
• apps/web/src/components/settings/KeybindingsSettings.logic.ts
• apps/web/src/keybindings.test.ts
• apps/web/src/keybindings.ts
• apps/web/src/routes/_chat.pull-requests.tsx
• docs/user/keybindings.md
• packages/shared/src/keybindings.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• docs/user/keybindings.md

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds isWeb and isDesktop shortcut context flags, restricts default thread and model-picker jump shortcuts to desktop contexts, and updates tests and documentation.

Changes

Web-aware keybinding conditions

Layer / File(s)	Summary
Add the platform shortcut context apps/web/src/keybindings.ts, apps/web/src/components/settings/KeybindingsSettings.logic.ts, apps/web/src/components/settings/KeybindingsSettings.logic.test.ts, apps/web/src/components/ChatView.tsx, apps/web/src/routes/_chat.pull-requests.tsx, apps/web/src/components/pullRequest/PullRequestDetailPanel.test.tsx	The shortcut context and settings options now include isWeb and isDesktop. Runtime defaults derive these values from isElectron.
Restrict platform-sensitive default shortcuts packages/shared/src/keybindings.ts	Thread jump defaults require isDesktop. Model-picker jump defaults require modelPickerOpen && isDesktop.
Validate and document platform-specific resolution apps/web/src/keybindings.test.ts, docs/user/keybindings.md	Tests cover web and desktop shortcut resolution. Documentation describes the platform context and updated jump defaults.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant KeybindingResolver
  participant ShortcutMatchContext
  Browser->>KeybindingResolver: press Cmd+1 or Cmd+3
  KeybindingResolver->>ShortcutMatchContext: evaluate isDesktop and modelPickerOpen
  ShortcutMatchContext-->>KeybindingResolver: return condition result
  KeybindingResolver-->>Browser: resolve command or return null

Loading

Suggested reviewers: bil0000

Merge Risk: ⚪ Minimal · up to 95c7a

The change has compatible web and Electron defaults, with tests covering browser suppression and desktop behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 8 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: preventing numbered keyboard shortcuts from overriding browser tab switching.
Description check	✅ Passed	The description includes the required What Changed, Why, UI Changes, and Checklist sections. It explains the shortcut behavior and the activity-group rendering change. The screenshot and video checkli…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 8 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}