refactor(web): share diagnostic process actions

[juliusmarminge]

Targets main independently. This PR has no dependency on V2 or another UI audit PR.

The two diagnostics process tables duplicated signal buttons and exposed different tooltip and accessibility defaults. ProcessSignalActions now renders SIGINT and SIGKILL using InlineButton and shared tooltips. Each table still owns PID identity, permissions, confirmation, and signal dispatch.

Validation: ResourceTelemetryDiagnostics.logic tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.

Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.

Model: GPT-6. Harness: Codex.

Summary by CodeRabbit

• Bug Fixes
  • Improved process diagnostics controls with consistent INT and KILL actions.
  • Prevented signal actions from being used while a process is actively signaling.
  • Ensured selected signals are applied to the intended process.

[github-actions]

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 36138bc.

This comment will update automatically after the next completed run.

[macroscopeapp]

Approvability

Verdict: Approved at 36138bc

Macroscope's review found this PR approvable — This is a localized refactor that centralizes existing diagnostic process actions while preserving process ownership and signal dispatch. Its only runtime differences are minor UI and accessibility improvements, with no schema, deployment, security, billing, or default-behavior impact.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: d9d1746a-8fef-45c7-adef-d3bf74d6e6aa

📥 Commits

Reviewing files that changed from the base of the PR and between 53510d4 and 36138bc.

📒 Files selected for processing (3)

• apps/web/src/components/settings/DiagnosticsSettings.tsx
• apps/web/src/components/settings/ProcessSignalActions.tsx
• apps/web/src/components/settings/ResourceTelemetryDiagnostics.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The change extracts process signal controls into a shared component. Both diagnostics views now use it, passing disabled state and callbacks for the selected process signal.

Changes

Process signal actions

Layer / File(s)	Summary
Extract shared signal controls apps/web/src/components/settings/ProcessSignalActions.tsx, apps/web/src/components/settings/DiagnosticsSettings.tsx	Adds the exported ProcessSignalActions component and removes the local implementation. The component renders disabled-aware SIGINT and SIGKILL buttons with tooltips and accessible labels.
Wire diagnostics views apps/web/src/components/settings/DiagnosticsSettings.tsx, apps/web/src/components/settings/ResourceTelemetryDiagnostics.tsx	Updates both diagnostics views to use the shared component. ProcessDiagnosticsTable binds the process PID, and signaling remains disabled when required by the existing state.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Refactor

Suggested reviewers: maria-rcks

Merge Risk: ⚪ Minimal · up to 36138

The shared controls retain distinct accessible labels and do not add duplicate screen-reader announcements. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: sharing diagnostic process actions in the web application.
Description check	✅ Passed	The description explains the shared component, the retained table responsibilities, validation performed, UI-validation limitations, and scope exclusions. It does not use the template headings or chec…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}