fix(mobile): show Agent behavior icon on Android - #12316
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused Android icon-rendering fix confined to the mobile symbol wrapper and menu presentation. It adds supported icon mappings and compile-time narrowing without changing product defaults, workflows, data contracts, or other production behavior. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe mobile symbol system now uses shared symbol types, expanded Android icon mappings, and runtime name validation. iOS and environment symbol consumers use the shared type. Android rendering prioritizes Material mappings before SF mappings. ChangesApp symbol support
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The Android icon change has no remaining actionable risk identified and is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
## What's Changed * fix(web): keep thoughts and failed tool calls in one activity row by @maria-rcks in pingdotgg/t3code#12270 * fix(web): avoid reopening settled threads when adding projects by @dominic-r in pingdotgg/t3code#11804 * feat(mobile): make Settings easier to navigate and scope by @juliusmarminge in pingdotgg/t3code#12272 * fix(mobile): prevent overlapping text and UI on Android chat messages by @Exotic209093 in pingdotgg/t3code#11611 * feat(web): pull request files can be marked as viewed by @yordis in pingdotgg/t3code#7721 * fix(web): keep composer banners compact and readable by @Bil0000 in pingdotgg/t3code#12166 * fix(web): collapse thoughts within tool groups by @maria-rcks in pingdotgg/t3code#12302 * fix(usage): preserve saved totals after transcript cleanup by @maria-rcks in pingdotgg/t3code#12304 * fix(mobile): show Agent behavior icon on Android by @juliusmarminge in pingdotgg/t3code#12316 ## New Contributors * @Exotic209093 made their first contribution in pingdotgg/t3code#11611 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260917.1866...v0.0.43-nightly.20260917.1880 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260917.1880
Android Settings renders the Agent behavior row without an icon because
text.alignlefthas no Android Tabler mapping. The mobile symbol wrapper accepts SF Symbols that its Android implementation would silently render asnull.Add the missing Android mappings found by narrowing the symbol name type to icons this wrapper can render. Validate SF and Material names against their platform types, share that contract with iOS, and check raw native-menu image strings before passing them to the icon component.
These crops are from one Pixel 10 Pro emulator, the same T3 Code Dev client, and one disposable connected environment. The base and PR head use the same viewport and Settings state.
Before, on
main(592021f0080):After, on this PR (
7c1a6563d4a):Mobile typecheck and targeted lint pass. React Doctor reports no issues in the changed files. The Android development client built locally and was verified against the disposable environment.
Model: withheld by request. Harness: Codex.
Summary by CodeRabbit
New Features
Bug Fixes