fix(mobile): support Android image attachments - #7375
Closed
mitchellmoss wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The provider attachment contract remains GIF, JPEG, PNG, and WebP.
Why
The native Android composer hides image picking until the editor expands. Android media providers can also return picker assets without base64 data, and HEIF or HEIC images do not match the provider upload contract.
Issue #2803 reports the same visible symptom on mobile web. This PR changes only the native Android client.
Checks completed:
vp test apps/mobile/src/lib/composerImages.test.ts(7 passed)vp lintvp format --checkvp run --filter @t3tools/mobile typecheckUI Changes
A clean before-and-after screenshot is still needed before this draft is marked ready. Device UI-tree verification confirmed the collapsed attachment control and selected-image thumbnail.
Checklist
Model: GPT-5.6-Sol
Harness: Codex in T3 Code
Note
Add Android image attachment support with HEIF-to-JPEG conversion in mobile composer
ControlPillbutton to the collapsed composer view in ThreadComposer.tsx that triggers image picking.pickComposerImagesin composerImages.ts to detect HEIF/HEIC images and convert them to JPEG usingexpo-image-manipulator, updating filename, MIME type, and preview URI accordingly.expo-file-systemwhen the Android image picker omits base64 data.sizeBytesis set toundefinedafter HEIF conversion and recomputed from base64, which may cause size limit checks to behave differently for converted images.Macroscope summarized ca961fc.