fix(mobile): render generic message attachments - #9929
Merged
shivamhwp merged 2 commits intoSep 5, 2026
Merged
Conversation
Contributor
|
Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies. |
saphid
force-pushed
the
fix/v2-mobile-file-rendering-20260905
branch
from
September 5, 2026 05:07
ada26fb to
2649ee3
Compare
saphid
marked this pull request as ready for review
September 5, 2026 07:11
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This isolated mobile fix removes an accidental image-only prefilter so existing attachment renderers can display PDFs, videos, generic files, and unknown attachments. Image handling remains unchanged, with no schema, infrastructure, security, billing, or default-setting impact. You can add or adjust custom eligibility rules. Learn more. |
shivamhwp
merged commit Sep 5, 2026
475aa8c
into
pingdotgg:t3code/codex-turn-mapping
23 checks passed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-image attachments disappeared from the React Native thread feed because an image-only filter removed them before renderer selection. Pass the complete attachment list to the existing image, PDF, video, and generic-file renderers.
Verified on an isolated iPhone 16 Pro simulator (iOS 26.5), using the same message, image and 53-byte text attachment against the same disposable V2 server. Before:
ThreadFeed.tsxfromb9fa1399c. After: #9929 head2649ee3ca, patch-identical in integrationfa6a1ab04. The native Debug build succeeded (exit 0); only the Metro JavaScript bundle changed between captures. Generic text files and images were exercised; PDF/video opening and Android were not separately exercised.Annotated evidence
Validation: React Native typecheck and targeted lint passed in the frozen integration run. The native snapshot exposes
Open release-notes.txtafter the fix and onlyOpen preview.pngbefore it. This changes React Native only; web/desktop and SwiftUI are separate clients.Targets Julius’s Orchestrator V2 branch in #2829. A direct
claude --model claude-opus-5 --effort high --print --tools '' --no-session-persistence --output-format jsonreview attempt exited 1 because OAuth expired before model execution; no Claude review occurred.Implemented and verified with GPT-6 Astra in Codex/T3.
Note
Low Risk
Single-line behavioral fix in mobile UI; attachment routing was already implemented downstream.
Overview
Non-image message attachments were hidden in the React Native thread feed because
ThreadFeedfilteredmessage.attachmentsto images only before rendering.The feed now passes the full attachment list into the existing per-type UI: images, file chips (PDF preview, video tiles, generic files via share), and unknown types as inert rows. No new renderers—only removal of the image-only filter in the message entry path for user and assistant bubbles.
Reviewed by Cursor Bugbot for commit 2649ee3. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix
renderFeedEntryto pass all message attachments, not just imagesThe message-entry renderer in ThreadFeed.tsx previously filtered
message.attachmentsto image attachments only. It now uses the fullmessage.attachmentslist (defaulting to empty when absent), so non-image attachments reach the feed.Macroscope summarized f3c0750.