Skip to content

Merge master into features - #5744

Merged
nicoddemus merged 21 commits into
pytest-dev:featuresfrom
nicoddemus:mm
Aug 15, 2019
Merged

Merge master into features#5744
nicoddemus merged 21 commits into
pytest-dev:featuresfrom
nicoddemus:mm

Conversation

@nicoddemus

Copy link
Copy Markdown
Member

No description provided.

timhoffm and others added 21 commits August 9, 2019 21:35
Improve docs of pytest.importorskip
Co-Authored-By: Bruno Oliveira <nicoddemus@gmail.com>
)

5669: pytester: add docstrings for Testdir.copy_example
Update URL: python/black → psf/black
test_non_ascii_paste_text: mock call to urlopen
Co-Authored-By: Bruno Oliveira <nicoddemus@gmail.com>
Do not treat warnings as errors during ``pytest_configure``.
warn for async generator functions
…-dev#5701)

check that tests that are partial staticmethods are supported
Conflicts:
	src/_pytest/outcomes.py
@codecov

codecov Bot commented Aug 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5744 into features will increase coverage by <.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5744      +/-   ##
============================================
+ Coverage     96.25%   96.25%   +<.01%     
============================================
  Files           117      117              
  Lines         25902    25948      +46     
  Branches       2495     2497       +2     
============================================
+ Hits          24932    24977      +45     
- Misses          666      667       +1     
  Partials        304      304
Impacted Files Coverage Δ
testing/python/collect.py 99.35% <ø> (-0.01%) ⬇️
src/_pytest/pytester.py 90.8% <ø> (ø) ⬆️
src/_pytest/outcomes.py 98.5% <ø> (ø) ⬆️
src/_pytest/config/__init__.py 94.43% <100%> (+0.01%) ⬆️
testing/test_warnings.py 94.76% <100%> (+0.22%) ⬆️
src/_pytest/compat.py 98.54% <100%> (+1.45%) ⬆️
testing/acceptance_test.py 98.05% <100%> (+0.02%) ⬆️
src/_pytest/python.py 95.54% <100%> (+0.02%) ⬆️
testing/test_pastebin.py 100% <100%> (ø) ⬆️
src/_pytest/fixtures.py 97.5% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0822a1e...1049a38. Read the comment docs.

@blueyed blueyed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handling dropped coverage in #5747.

Comment thread src/_pytest/compat.py
is_method = hasattr(obj, "__func__")
obj = get_real_func(obj)
except Exception:
except Exception: # pragma: no cover

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wut?
Rather leave it show up in reports..

@nicoddemus

Copy link
Copy Markdown
Member Author

Thanks! Please rebase #5747 on features as I plan to release 5.1.0 right away. 👍

@nicoddemus
nicoddemus merged commit 0f11a7a into pytest-dev:features Aug 15, 2019
@nicoddemus
nicoddemus deleted the mm branch August 15, 2019 22:12
@blueyed

blueyed commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

You can/should release regardless of #5747, no? (which is not going to merged right away)

@nicoddemus

Copy link
Copy Markdown
Member Author

Yep, only later I saw it closely and noticed it did not affect the release in the end. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants