feat(price_feeds/starknet): add JS examples and update contract#13
Merged
Conversation
ali-behjati
reviewed
Jun 7, 2024
Contributor
There was a problem hiding this comment.
to me it seems that this one should become an example of the sdk.
Contributor
Author
There was a problem hiding this comment.
Should I put it in pyth-crosschain/target_chains/starknet/sdk/js/src/examples? @aditya520 what do you think?
Contributor
Author
There was a problem hiding this comment.
Decided to put in pyth-crosschain after discussion. I've removed it from this PR.
Riateche
force-pushed
the
starknet-js-example
branch
from
0d5b5d1 to
2a72b2f
Compare
ali-behjati
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to properly include the SDK from Github repository, so I've put a file reference for now (assuming
pyth-crosschainandpyth-examplesare in the same directory). Once we publish the SDK to the registry, we can simply include it by version.