Skip to content

feat(price_feeds/starknet): simplify contract, use STRK, add CI#14

Merged
Riateche merged 3 commits into
mainfrom
starknet-example-improvements
Jun 18, 2024
Merged

feat(price_feeds/starknet): simplify contract, use STRK, add CI#14
Riateche merged 3 commits into
mainfrom
starknet-example-improvements

Conversation

@Riateche

@Riateche Riateche commented Jun 11, 2024

Copy link
Copy Markdown
Contributor
  • Hardcode price feed ID to simplify the example
  • Use STRK fee instead of ETH to align with our recommendation
  • Use STRK/USD price feed
  • Add minimal CI (just contract build for now, will add more later)

This PR is on top of #13. Please see the second commit only.

@Riateche Riateche marked this pull request as draft June 11, 2024 12:25
@Riateche Riateche changed the title Starknet example improvements feat(price_feeds/starknet): simplify contract, use STRK, add CI Jun 11, 2024
@Riateche Riateche force-pushed the starknet-example-improvements branch from e6f0011 to 5af8d43 Compare June 11, 2024 12:31
@Riateche Riateche marked this pull request as ready for review June 11, 2024 12:32
@Riateche Riateche force-pushed the starknet-example-improvements branch 2 times, most recently from df6cecf to f9a95a9 Compare June 11, 2024 14:23
@Riateche Riateche force-pushed the starknet-example-improvements branch from fbb0f3d to e056fde Compare June 18, 2024 12:40
@Riateche Riateche merged commit 0cb9415 into main Jun 18, 2024
@Riateche Riateche deleted the starknet-example-improvements branch June 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants