traduction tutorial/inputouput#1080
Merged
Merged
Conversation
Seluj78
previously requested changes
Dec 13, 2019
Seluj78
left a comment
Seluj78
left a comment
Collaborator
There was a problem hiding this comment.
Super première PR ! Merci beaucoup ! 🎉
christopheNan
left a comment
christopheNan
left a comment
Contributor
There was a problem hiding this comment.
Merci pour cette première contribution.
| "``f.read()`` will return an empty string (``''``). ::" | ||
| msgstr "" | ||
| "Pour lire le contenu d'un fichier, appelez ``f.read(taille)`` : elle lit une " | ||
| "Pour lire le contenu d'un fichier, appelez ``f.read(size)``, qui lit une " |
Contributor
There was a problem hiding this comment.
Dans ce paragraphe, le paramètre size avait été traduit car il n'est pas utilisé ailleurs. C'est contraire aux directives du README mais c'est réfléchi.
Tu peux le remettre en anglais, mais je trouve ça dommage.
Contributor
There was a problem hiding this comment.
Oups, c'est ma faute. Mais avec tes explications, ça me va !
Collaborator
|
Hello @QuentinGuiheneuc, des news? 🏓 |
Collaborator
|
Hello @QuentinGuiheneuc, ping ! |
Collaborator
|
je reprends |
Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
Collaborator
|
@christopheNan revue stp, j'ai vu que tu avais bossé sur ce fichier récemment. |
christopheNan
approved these changes
May 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1076 c'est ma premiere pull request