Skip to content

Relecture complète et complément de library/csv.po#1798

Merged
JulienPalard merged 12 commits into
python:3.10from
PhilippeGalvan:library.csv.po
May 23, 2022
Merged

Relecture complète et complément de library/csv.po#1798
JulienPalard merged 12 commits into
python:3.10from
PhilippeGalvan:library.csv.po

Conversation

@PhilippeGalvan

Copy link
Copy Markdown
Contributor

closes #1781

@awecx awecx left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette PR. Quelques remarques de formes à corriger et deux ou trois de fond à discuter.

Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
awecx
awecx previously requested changes Jan 3, 2022
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
@Seluj78 Seluj78 added the 🤖 automerge The PR will be auto merged label Feb 22, 2022
@PyDocTeur

Copy link
Copy Markdown

Je mergerai cette PR dès que les tests passeront et qu'elle sera approuvée.


Disclaimer

Je suis un robot fait par l'équipe de l'AFPy et de Traduction
sur leur temps libre. Je risque de dire des bétises. Ne me blâmez pas, blamez les développeurs.

Code source

I'm a bot made by the Translation and AFPy teams on their free
time. I might say or do dumb things sometimes. Don't blame me, blame the developer !

Source code

(state: automerge)
PyDocTeur v1.12.0

deronnax and others added 2 commits May 20, 2022 10:13
Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
@jeanas

jeanas commented May 21, 2022

Copy link
Copy Markdown
Collaborator

J'ai fusionné avec 3.10. @PhilippeGalvan Si cela ne te dérange pas, je compte reprendre cette PR.

Comment thread library/csv.po
Comment thread library/csv.po Outdated
Comment thread library/csv.po Outdated
Comment thread library/csv.po
@jeanas

jeanas commented May 21, 2022

Copy link
Copy Markdown
Collaborator

Pour moi c'est prêt à être mergé, qu'en pensez-vous @christopheNan @awecx ?

JulienPalard
JulienPalard previously approved these changes May 23, 2022
Comment thread library/csv.po Outdated
@JulienPalard JulienPalard merged commit 5ca18fe into python:3.10 May 23, 2022
@JulienPalard

Copy link
Copy Markdown
Member

Merci tous pour cette PR !

J'ai jamais vu autant de "Co-Authored-By" dans une PR :

commit 5ca18fea1bad6f5fa5970f790df29d29be693063 (upstream/3.10)
Author: PhilippeGalvan <git.philippeG@outlook.com>
Date:   Mon May 23 14:19:30 2022 +0200

    Relecture complète et complément de library/csv.po (#1798)
    
    Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
    Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
    Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>
    Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
    Co-authored-by: Julien Palard <julien@palard.fr>

JulienPalard added a commit that referenced this pull request May 24, 2022
Co-authored-by: Antoine <43954001+awecx@users.noreply.github.com>
Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Co-authored-by: Mathieu Dupuy <deronnax@gmail.com>
Co-authored-by: Jean Abou-Samra <jean@abou-samra.fr>
Co-authored-by: Julien Palard <julien@palard.fr>
@PhilippeGalvan PhilippeGalvan deleted the library.csv.po branch July 13, 2022 14:40
@PhilippeGalvan

Copy link
Copy Markdown
Contributor Author

Désolé pour l'absence et merci @jean-abou-samra pour la reprise ! Merci à tous pour les relectures et la cloture :) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 automerge The PR will be auto merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Je travaille sur library/csv.po

8 participants