Skip to content

translate library/unittest.mock#820

Merged
ken71301 merged 16 commits into
python:3.12from
ken71301:translate-mock
Mar 25, 2024
Merged

translate library/unittest.mock#820
ken71301 merged 16 commits into
python:3.12from
ken71301:translate-mock

Conversation

@ken71301

@ken71301 ken71301 commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

to rst:2286

mattwang44
mattwang44 reviewed Feb 22, 2024
View reviewed changes
Comment thread library/unittest.mock.po Outdated
@ken71301 ken71301 marked this pull request as ready for review February 23, 2024 00:00
ken71301
ken71301 commented Feb 23, 2024
View reviewed changes

@ken71301 ken71301 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
@mattwang44 mattwang44 self-requested a review March 5, 2024 15:47
@mindihx mindihx self-requested a review March 14, 2024 12:41
mindihx
mindihx reviewed Mar 16, 2024
View reviewed changes

@mindihx mindihx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

剩下 autospeccing 那段，先存檔

Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
mindihx
mindihx reviewed Mar 17, 2024
View reviewed changes

@mindihx mindihx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
@ken71301 ken71301 requested a review from mindihx March 18, 2024 13:50
mindihx
mindihx reviewed Mar 23, 2024
View reviewed changes
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
Comment thread library/unittest.mock.po Outdated
@ken71301 @mindihx
Apply suggestions from code review
70341ed 
for review p2.

Co-authored-by: mindihx <ymhuang.ymh@gmail.com>
@ken71301 ken71301 requested a review from mindihx March 24, 2024 14:05
@ken71301 ken71301 merged commit f3db31b into python:3.12 Mar 25, 2024
@ken71301 ken71301 deleted the translate-mock branch March 25, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mindihx mindihx mindihx approved these changes
@mattwang44 mattwang44 Awaiting requested review from mattwang44

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ken71301 @mattwang44 @mindihx