Skip to content

Refactor App Bootstrapping & DI Ownership Model#457

Merged
armanist merged 80 commits into
quantum-php:masterfrom
armanist:issue/373-app-bootstrapping
Apr 20, 2026
Merged

Refactor App Bootstrapping & DI Ownership Model#457
armanist merged 80 commits into
quantum-php:masterfrom
armanist:issue/373-app-bootstrapping

Conversation

@armanist

Copy link
Copy Markdown
Collaborator

Summary

Complete refactoring of the Quantum PHP Framework application bootstrapping, dependency injection, and service ownership model. This introduces explicit application lifecycle boundaries, an instance-based DI container, and eliminates all static singleton patterns from core services.

Key changes

  • AppContext as the central execution state holder per application run
  • DiContainer instance-based container with strict Di::get() contract (must register before resolving)
  • BootPipeline with ordered boot stages replacing implicit trait-based boot logic
  • Request/Response converted from static facades to instance-based classes
  • All 12 factories migrated from static instance caches to DI-managed lifetimes
  • All service singletons (Cookie, Config, Environment, Server, Database, etc.) migrated to DI ownership
  • Environment uses createArrayBacked() for isolated env loading, with environment() helper and shorthand methods

Guiding principle

Application execution defines scope. DI defines lifetime. Factories define construction.

Closes

Closes #373
Closes #374
Closes #375
Closes #376
Closes #377
Closes #378
Closes #379
Closes #380
Closes #381
Closes #382
Closes #452
Closes #454
Closes #455
Closes #456

armanist added 30 commits April 7, 2026 13:05
@armanist

Copy link
Copy Markdown
Collaborator Author

@coderabbitai help

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
  • @coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
  • @coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve merge conflict to automatically resolve merge conflicts.
  • @coderabbitai autofix to automatically fix issues identified in unresolved review comments.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai generate configuration to create a PR that adds the current resolved configuration as .coderabbit.yaml (or show it if already present).
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit configuration file (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, support, documentation and community

  • Visit our status page to check the current availability of CodeRabbit.
  • Create a ticket on our support page for assistance with any issues or questions.
  • Visit our documentation site for detailed information on how to use CodeRabbit.
  • Join our Discord community to connect with other users and get help from the community.
  • Follow us on X/Twitter for updates and announcements.

@armanist

Copy link
Copy Markdown
Collaborator Author

@coderabbitai summary

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown
✅ Actions performed

Summary regeneration triggered.

@armanist

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Comment thread src/App/Stages/InitHttpStage.php Outdated
Comment thread src/App/Factories/AppFactory.php Outdated
Comment thread src/Config/Config.php Outdated
Comment thread src/Config/Config.php Outdated
Comment thread src/Model/Factories/ModelFactory.php
Comment thread src/View/Factories/ViewFactory.php Outdated
Comment thread tests/Unit/App/Adapters/ConsoleAppAdapterTest.php Outdated
Comment thread src/App/AppContext.php Outdated
@armanist

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@armanist armanist requested a review from andrey-smaelov April 17, 2026 12:27
@armanist armanist merged commit ef2b7c3 into quantum-php:master Apr 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request help wanted Extra attention is needed new feature

Projects

None yet

3 participants