[Website] Upgrade all dependencies. Use React 14. by christopherdro · Pull Request #4570 · react/react-native

christopherdro · 2015-12-04T19:31:01Z

Required changes to get website running locally.

facebook-github-bot · 2015-12-04T19:31:30Z

By analyzing the blame information on this pull request, we identified @vjeux, @tadeuzagallo and @fkling to be potential reviewers.

vjeux · 2015-12-04T19:52:06Z

Feel free to merge if the site is still running, lgtm

ide · 2015-12-04T20:40:53Z

The test failed, here's the relevant bits of the error...

Bundling 161 JS files for /react-native/404.html   -   HTML blocks UI, JS Gen does not
HTML Gen:        
Error: SyntaxError: Unexpected token :
    at /Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/guard.js:27:12
    at onOutputGenerated (/Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/index.js:96:9)
    at Object.renderReactPage.done (/Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/DefaultRouter.js:345:7)
    at renderReactPage (/Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/renderReactPage.js:130:17)
    at renderComponentPackage (/Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/DefaultRouter.js:331:3)
    at routePackageHandler (/Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/DefaultRouter.js:274:5)
    at onComputePackage (/Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/index.js:100:9)
    at /Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/guard.js:29:10
    at onWarmed (/Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/Packager.js:270:9)
    at /Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/node_modules/async/lib/async.js:116:25
    at /Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/node_modules/async/lib/async.js:24:16
    at transformModuleImpl (/Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/Packager.js:206:5)
    at /Users/travis/build/facebook/react-native/website/node_modules/react-page-middleware/src/Packager.js:234:9
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:380:3)

That's about as specific as it gets unfortunately.

christopherdro · 2015-12-05T04:24:36Z

@ide No real luck yet trying to figure out whats going on. Running node /server/generate.js doesn't reproduce any errors. The only real difference i've been able to notice is where locally its shows
Bundling 160 JS files for /react-native/404.html whereas on Travis is shows Bundling 161 JS files for /react-native/404.html.

facebook-github-bot · 2015-12-06T07:34:19Z

@christopherdro updated the pull request.

christopherdro · 2015-12-06T19:46:36Z

So the build for the website passes when using Node 5 instead of 4 on travis.
However, this causes the obj-c test to fail.

I also attempted to switch to the latest version of xcode 7.1 and came across facebookarchive/xctool#619. This is probably worth opening up a separate issue but I just wanted to reference it here first.

Will continue looking into it.

facebook-github-bot · 2015-12-30T04:42:02Z

@christopherdro updated the pull request.

christopherdro · 2015-12-30T04:50:28Z

@vjeux @ide
Looks like the website test is passing now. I ran the test a few times to double check.

vjeux · 2015-12-30T05:10:50Z

@skevy was looking into it today. Can you review? Lgtm

skevy · 2015-12-30T06:50:08Z

I'll merge in the morning.

Tomorrow (or over he holiday) I'm going to actually go through and modernize this website codebase a bit...but this PR is a good first step. Gracias @christopherdro

christopherdro · 2015-12-30T07:00:16Z

👍 Sounds good! Thanks @skevy

christopherdro · 2016-01-02T16:24:30Z

@skevy Any updates? Would like to get this merged in.

satya164 · 2016-01-02T16:26:03Z

There are conflicts now!

christopherdro · 2016-01-02T16:55:16Z

Ya thats from #5080 being merged in

facebook-github-bot · 2016-01-02T17:00:20Z

@christopherdro updated the pull request.

facebook-github-bot · 2016-01-02T17:01:16Z

@christopherdro updated the pull request.

christopherdro · 2016-01-02T17:03:31Z

Not sure what happened here. I guess just forget about this PR.

skevy · 2016-01-02T21:15:15Z

@christopherdro sorry about that. I honestly just got busy with the holidays and forgot. :(

Did #5080 fix the same things as this PR...or do we still need to do what's in here?

christopherdro · 2016-01-02T21:25:07Z

It appears #5080 had a few of the same changes but mine were based on upgrading React to 0.14.5 and all other dependencies to the their latest versions.

I tried rebasing to master and resolve the merge conflicts but screwed up on something.

vjeux · 2016-01-02T21:32:37Z

You guys all have commit access, feel free to merge it in whenever this is working

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Dec 4, 2015

christopherdro force-pushed the website-update branch 2 times, most recently from 941df66 to f54c9c6 Compare December 5, 2015 00:27

christopherdro force-pushed the website-update branch 2 times, most recently from bf0c0a9 to 7b654b1 Compare December 6, 2015 07:33

christopherdro force-pushed the website-update branch 3 times, most recently from 6457de8 to 0a88adb Compare December 6, 2015 18:55

christopherdro force-pushed the website-update branch 2 times, most recently from 0f6361c to 3712f15 Compare December 10, 2015 16:40

skevy added GH Review: needs-revision and removed GH Review: review-needed labels Dec 12, 2015

jsierles mentioned this pull request Dec 14, 2015

UIExplorer component navigation support for an embedded simulator in the documentation site #3419

Closed

christopherdro force-pushed the website-update branch from 3712f15 to 3e721a6 Compare December 17, 2015 04:16

christopherdro mentioned this pull request Dec 18, 2015

[Node 5] Run Travis CI tests with Node 5 and npm 3 #3802

Merged

christopherdro force-pushed the website-update branch 2 times, most recently from cfaad7d to 49bc5f9 Compare December 30, 2015 04:41

christopherdro added GH Review: review-needed and removed GH Review: needs-revision labels Dec 30, 2015

christopherdro force-pushed the website-update branch from 49bc5f9 to a56455e Compare January 2, 2016 16:59

christopherdro closed this Jan 2, 2016

christopherdro force-pushed the website-update branch from a56455e to f39d45e Compare January 2, 2016 17:00

christopherdro deleted the website-update branch January 2, 2016 17:04

Uh oh!

Conversation

christopherdro commented Dec 4, 2015

Uh oh!

facebook-github-bot commented Dec 4, 2015

Uh oh!

vjeux commented Dec 4, 2015

Uh oh!

ide commented Dec 4, 2015

Uh oh!

christopherdro commented Dec 5, 2015

Uh oh!

facebook-github-bot commented Dec 6, 2015

Uh oh!

christopherdro commented Dec 6, 2015

Uh oh!

facebook-github-bot commented Dec 30, 2015

Uh oh!

christopherdro commented Dec 30, 2015

Uh oh!

vjeux commented Dec 30, 2015

Uh oh!

skevy commented Dec 30, 2015

Uh oh!

christopherdro commented Dec 30, 2015

Uh oh!

christopherdro commented Jan 2, 2016

Uh oh!

satya164 commented Jan 2, 2016

Uh oh!

christopherdro commented Jan 2, 2016

Uh oh!

facebook-github-bot commented Jan 2, 2016

Uh oh!

facebook-github-bot commented Jan 2, 2016

Uh oh!

christopherdro commented Jan 2, 2016

Uh oh!

skevy commented Jan 2, 2016

Uh oh!

christopherdro commented Jan 2, 2016

Uh oh!

vjeux commented Jan 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants