Fix issues running the website locally on windows with npm3 - #5080
Merged
Conversation
Contributor
facebook-github-bot
added
GH Review: review-needed
CLA Signed
vjeux
added a commit
that referenced
this pull request
Jan 2, 2016
Fix issues running the website locally on windows with npm3
Contributor
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a few issues running the website locally on Windows with npm3.
Windows issues
packager/blacklist.js
The packager was not properly ignoring the website node_modules which caused errors with the haste modules.
website/server/convert.js
splitHeader didn't work properly because of \r\n
npm3 issues
Not 100% sure about this one but the website used react@0.12 while react-page-middleware used react-tools @0.13. Updating react to 0.13 fixed the problem. I also fixed some warning about not using factory functions by using jsx instead and remove the transferPropsTo call that doesn't exist anymore in react@0.13.