Adopt the lombok@1.18.27 edge release#3031
Merged
testforstephen merged 1 commit intoMar 30, 2023
Merged
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Eskibear
reviewed
Mar 30, 2023
| .on("error", reject) | ||
| .on('end', () => { | ||
| fse.renameSync("./lombok/lombok-edge.jar", "./lombok/lombok-1.18.27.jar"); | ||
| resolve(); |
Contributor
There was a problem hiding this comment.
LGTM.
just wondering if we can simply put done() here without adding new promise/async/await stuffs?
Contributor
There was a problem hiding this comment.
Anyway, just forget about it, it doesn't matter.
snjeza
approved these changes
Mar 30, 2023
gayanper
pushed a commit
to gayanper/vscode-java
that referenced
this pull request
May 27, 2023
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See projectlombok/lombok#3332 (comment), this fixes a significant lombok regression #2887.