Skip to content

Adopt the lombok@1.18.27 edge release #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
testforstephen merged 1 commit into from
Mar 30, 2023
+22 −6
Merged

Adopt the lombok@1.18.27 edge release #3031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,31 @@ gulp.task('download_jre', async function (done) {
done();
});

gulp.task('download_lombok', function (done) {
gulp.task('download_lombok', async function (done) {
if (fse.existsSync('./lombok')) {
fse.removeSync('./lombok');
}
const lombokVersion = '1.18.24';
// The latest lombok version can be found on the website https://projectlombok.org/downloads
const lombokUrl = `https://projectlombok.org/downloads/lombok-${lombokVersion}.jar`;
download(lombokUrl)
.pipe(gulp.dest('./lombok/'))

await new Promise(function (resolve, reject) {
// Adopt lombok-1.18.27 edge release for the issue https://github.com/redhat-developer/vscode-java/issues/2887
download("https://projectlombok.org/lombok-edge.jar")
.pipe(gulp.dest('./lombok/'))
.on("error", reject)
.on('end', () => {
fse.renameSync("./lombok/lombok-edge.jar", "./lombok/lombok-1.18.27.jar");
resolve();

@Eskibear Eskibear Mar 30, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

just wondering if we can simply put done() here without adding new promise/async/await stuffs?

@Eskibear Eskibear Mar 30, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, just forget about it, it doesn't matter.

});

// TODO: Switch to stable version once lombok 1.18.28 is released.

// const lombokVersion = '1.18.24';
// // The latest lombok version can be found on the website https://projectlombok.org/downloads
// const lombokUrl = `https://projectlombok.org/downloads/lombok-${lombokVersion}.jar`;
// download(lombokUrl)
// .pipe(gulp.dest('./lombok/'))
// .on("error", reject)
// .on('end', resolve);
});
done();
});

Expand Down