Clarified get_matching_xpath_count returns str#714
Closed
GLMeece wants to merge 1 commit into
Closed
Conversation
Updated documentation to include the return type (string) of the XPath count.
Contributor
|
Do you want to add your name to the CHANGES.rst and could you open a issue? |
Member
|
Simple doc fixes could, in my opinion, be mergen also without issues. Also, I agree int would be better type but changing would be backwards incompatible. Updating docs is a very good idea. Thanks for PR! |
Contributor
Author
|
For formality's sake, I have created an issue, which includes Pekka's suggestion to have it optionally return an int as a keyword arg (still keeping a string return as the default). |
Contributor
|
Should we close this one and consentrate on #717 |
Contributor
|
Closed to favor #735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated documentation to include the return type (string) of the XPath count.
Many users would assume that the "count" is an integer. However, since the count value is cast to a string upon return, this is not the case. Since this behavior has been in the code for quite awhile, likely as not users have coded around it. However, for accuracy's sake (as well as for those just learning RF).