Redis intransit encryption support - #651
Closed
dirkonly wants to merge 7 commits into
Closed
Conversation
…nto redis_intransit_encryption_support
…nly/javascript-client into redis_intransit_encryption_support
dirkonly
marked this pull request as ready for review
March 3, 2022 13:23
Contributor
|
Hi, @dirkonly , We are working on a refactor of the SDK internal dependencies, to reuse code from https://github.com/splitio/javascript-commons . Even though we won't merge this PR, we're thankful for the contribution. |
Contributor
|
Hi @dirkonly , I am closing your PR, since we have applied it to these files: RedisAdapter, storage/node, recently released with version 10.18.0 of the SDK. Thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
in-transit encryption support added. The 'tls' option was not sent to the redis client and therefor connections to our encrypted redis could not be made
How do we test the changes introduced in this PR?
Initialize splitio in consumer mode and use an encrypted redis storage