[JS-commons migration] Redis intransit encryption support - #653
Merged
EmilianoSanchez merged 14 commits intoApr 4, 2022
Conversation
EmilianoSanchez
changed the title
gsiwatch
reviewed
Mar 21, 2022
| redisTlsSkipNameValidation, | ||
| redisTlsClientCertificate, | ||
| redisTlsClientKey | ||
| } = options; |
There was a problem hiding this comment.
Not a part of this PR: but just wondering
will it be possible to define a type for this Object so that clients using it can know what options they can use instead of coming here and checking the code?
Currently this is what I am seeing in Node SDK 10.17.0
readonly storage: {
prefix: string,
options: Object, <-- type here
type: StorageType
},
Contributor
Author
There was a problem hiding this comment.
That's a good point. We will include the type of the options object :)
emmaz90
approved these changes
Mar 21, 2022
EmilianoSanchez
force-pushed
the
redis_intransit_encryption_support
branch
from
March 21, 2022 23:08
944f371 to
61f7109
Compare
EmilianoSanchez
force-pushed
the
redis_intransit_encryption_support
branch
from
March 22, 2022 19:42
61f7109 to
ff0b84d
Compare
NicoZelaya
approved these changes
Mar 25, 2022
| * @property {SplitIO.RedisStorageOptions} options | ||
| */ | ||
| options?: Object, | ||
| options?: SplitIO.RedisStorageOptions, |
Contributor
There was a problem hiding this comment.
Feedback discussed on Slack, but consider making this assignment dynamic based on the storage type.
EmilianoSanchez
force-pushed
the
redis_intransit_encryption_support
branch
from
March 29, 2022 18:51
74a5977 to
889d86b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes