Skip to content

Fix react-native@0.70 compatibility - .destroy() function now works#37

Merged
EmilianoSanchez merged 7 commits into
splitio:developmentfrom
StasDoskalenko:fix/react-native-0.70-compatibility
Nov 30, 2022
Merged

Fix react-native@0.70 compatibility - .destroy() function now works#37
EmilianoSanchez merged 7 commits into
splitio:developmentfrom
StasDoskalenko:fix/react-native-0.70-compatibility

Conversation

@StasDoskalenko

@StasDoskalenko StasDoskalenko commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

NativeEventSubscription interface has been changed in newer RN versions

React Native SDK

What did you accomplish?

I fixed the crash when clients destroy function has been called

How do we test the changes introduced in this PR?

Try to Destry split.io client in newer RN versions

Extra Notes

resolves #38

EmilianoSanchez and others added 7 commits March 31, 2022 19:39
@EmilianoSanchez
EmilianoSanchez changed the base branch from main to development November 30, 2022 21:38
@EmilianoSanchez
EmilianoSanchez merged commit a831f65 into splitio:development Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

calling "destroy()" function crashes the app

4 participants