Skip to content

Fix react-native@0.70 compatibility - .destroy() function now works #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmilianoSanchez merged 7 commits into from
Nov 30, 2022
Merged

Fix react-native@0.70 compatibility - .destroy() function now works #37

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
329f529
Merge pull request #22 from splitio/development
EmilianoSanchez Mar 31, 2022
0d0a5e6
Merge pull request #24 from splitio/development
EmilianoSanchez Apr 7, 2022
b09aab4
Merge pull request #26 from splitio/development
EmilianoSanchez May 24, 2022
30066c5
Merge pull request #28 from splitio/development
EmilianoSanchez May 24, 2022
81a1463
Merge pull request #30 from splitio/development
NicoZelaya Jul 6, 2022
6e36723
Merge pull request #36 from splitio/development
EmilianoSanchez Oct 5, 2022
8370364
fix react-native@0.70 compatibility
StasDoskalenko Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/platform/RNSignalListener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { CLEANUP_REGISTERING, CLEANUP_DEREGISTERING } from '@splitsoftware/split
import { ISyncManager } from '@splitsoftware/splitio-commons/src/sync/types';
import { ISettings } from '@splitsoftware/splitio-commons/src/types';
import { AppState, AppStateStatus } from 'react-native';
import type { NativeEventSubscription } from 'react-native';

type Transition = undefined | 'TO_FOREGROUND' | 'TO_BACKGROUND';
const TO_FOREGROUND = 'TO_FOREGROUND';
Expand All @@ -18,6 +19,7 @@ const EVENT_NAME = 'for AppState change events.';
*/
export class RNSignalListener implements ISignalListener {
private _lastTransition: Transition | undefined;
private _appStateSubscription: NativeEventSubscription | undefined;

constructor(private syncManager: ISyncManager, private settings: ISettings & { flushDataOnBackground?: boolean }) {}

Expand Down Expand Up @@ -85,7 +87,7 @@ export class RNSignalListener implements ISignalListener {
// Checking currentState in the rare case that the SDK is instantiated in background, where streaming should not connect.
// The SDK should be instantiated when React Native JS context is initiated or the root componentDidMount method is called, where the app is in the foreground.
this._handleAppStateChange(AppState.currentState);
AppState.addEventListener('change', this._handleAppStateChange);
this._appStateSubscription = AppState.addEventListener('change', this._handleAppStateChange);
}

/**
Expand All @@ -94,6 +96,7 @@ export class RNSignalListener implements ISignalListener {
*/
stop() {
this.settings.log.debug(CLEANUP_DEREGISTERING, [EVENT_NAME]);
AppState.removeEventListener('change', this._handleAppStateChange);
this._appStateSubscription?.remove();
}
}