fix(cli): make env shims use the active vp executable by leohara · Pull Request #1631 · voidzero-dev/vite-plus

leohara · 2026-05-19T13:27:11Z

Summary

Fix Unix env shims created by vp env setup so they point to the active vp executable instead of always assuming the standalone VP_HOME/current/bin/vp layout.

This keeps the existing standalone behavior when the active executable is VP_HOME/current/bin/vp, while making Homebrew-style installs work when vp lives outside VP_HOME.

Fixes #1572 .

Details

Resolve the Unix shim target from the currently running vp
Preserve ../current/bin/vp for standalone installs
Recreate stale or broken Unix core shim symlinks without requiring --refresh.
Add a global snap test that simulates an external/Homebrew-style vp and verifies:
- shims point to the external vp
- command -v node resolves to the Vite+ shim
- node -v uses the project Node version

Note

This PR intentionally keeps the scope focused on vp env setup core shims. I noticed that package binary shims created by vp install -g also use the ../current/bin/vp Unix target today, but I left that out to keep this PR focused on the reported Homebrew node shim issue. If you’d prefer fixing those package shims in the same PR, I’m happy to add that follow-up change here.

Verification

cargo test -p vite_global_cli shim -- --nocapture
pnpm bootstrap-cli
pnpm -C packages/cli snap-test-global command-env-setup-external-vp
vp check --fix
cargo clippy -p vite_global_cli --all-targets
cargo fmt --check
git diff --check

netlify · 2026-05-19T13:27:20Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`7d87192`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a12a2d6b5697600086424e3

fengmk2 · 2026-05-20T13:13:03Z

@codex review

chatgpt-codex-connector · 2026-05-20T13:17:26Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…/homebrew-env-shims

… fix/homebrew-env-shims

fengmk2

@leohara Thanks!

fengmk2 · 2026-05-22T06:12:37Z

@leohara It looks like this change would cause the E2E Test to hang?

fengmk2 · 2026-05-22T06:41:11Z

@leohara It looks like this change would cause the E2E Test to hang?

Ignore my reply, it seems that the main branch also has this issue. I'll check why https://github.com/voidzero-dev/vite-plus/actions/runs/26228753482

fengmk2 · 2026-05-24T07:03:54Z

e2e fails will be fixed in #1668

) ## Summary Fix Unix env shims created by `vp env setup` so they point to the active `vp` executable instead of always assuming the standalone `VP_HOME/current/bin/vp` layout. This keeps the existing standalone behavior when the active executable is `VP_HOME/current/bin/vp`, while making Homebrew-style installs work when `vp` lives outside `VP_HOME`. Fixes voidzero-dev#1572 . ## Details - Resolve the Unix shim target from the currently running `vp` - Preserve `../current/bin/vp` for standalone installs - Recreate stale or broken Unix core shim symlinks without requiring --refresh. - Add a global snap test that simulates an external/Homebrew-style `vp` and verifies: - shims point to the external `vp` - `command -v node` resolves to the Vite+ shim - `node -v` uses the project Node version > [!NOTE] > This PR intentionally keeps the scope focused on `vp env setup` core shims. I noticed that package binary shims created by `vp install -g` also use the `../current/bin/vp` Unix target today, but I left that out to keep this PR focused on the reported Homebrew `node` shim issue. If you’d prefer fixing those package shims in the same PR, I’m happy to add that follow-up change here. ## Verification - `cargo test -p vite_global_cli shim -- --nocapture` - `pnpm bootstrap-cli` - `pnpm -C packages/cli snap-test-global command-env-setup-external-vp` - `vp check --fix` - `cargo clippy -p vite_global_cli --all-targets` - `cargo fmt --check` - `git diff --check` --------- Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>

@fengmk2

Release vite-plus v0.1.23. Enterprise-ready HTTP (proxy + custom CA), task command shorthands in `vite.config.ts`, a smoother `vp create`/`vp migrate`, and the oxc/vite/rolldown bundled stack moves forward. ### Highlights - **Proxy and custom-CA aware HTTP**: a new process-wide `vite_shared::shared_http_client()` honors `HTTPS_PROXY` / `HTTP_PROXY` / `NO_PROXY`, picks up macOS System Settings / Windows registry proxies, loads custom CAs from `SSL_CERT_FILE` and `NODE_EXTRA_CA_CERTS`, and exposes a `VP_INSECURE_TLS` diagnostic switch; makes `vp` work through Socket Firewall Free and other TLS-intercepting proxies ([#1686](#1686)), by @fengmk2 - **Task command shorthands**: `run.tasks` entries in `vite.config.ts` now accept a bare string (`"build": "cmd"`) or array (`"build": ["cmd1", "cmd2"]`) instead of always requiring `{ command: ... }`; arrays reuse the existing `&&` planning path so cache, `dependsOn`, and task options stay consistent ([vite-task#391](voidzero-dev/vite-task#391)), by @jong-kyung - **Managed `vp outdated -g`**: routes through Vite+'s managed global package metadata instead of delegating to the underlying `npm outdated -g` store, so all installed global packages are reported consistently ([#1659](#1659)), by @liangmiQwQ ### Features - `vp pm approve-builds`: new unified subcommand that mirrors `pnpm approve-builds` one-to-one, adapts to `bun pm trust`, and warns-and-noops on npm/yarn ([#1662](#1662)), by @fengmk2 - `vp create`: opt-in GitHub Copilot setup; selecting `--agent copilot` now generates a `.github/workflows/copilot-setup-steps.yml` so the Copilot Coding Agent can set up Vite+ and run `vp` in the new project out of the box ([#1683](#1683)), by @jong-kyung - `vp migrate`: prompt to remove `baseUrl` from `tsconfig.json` before applying type-aware lint defaults (runs `@andrewbranch/ts5to6 --fixBaseUrl .` under the hood; auto-applied in non-interactive mode) ([#1692](#1692)), by @TheAlexLichter - Respect `packageManager` in package-manager shims (`npm`/`npx`, `pnpm`/`pnpx`, `yarn`/`yarnpkg`, `bun`/`bunx`); add non-mutating `packageManager` resolution metadata for `vp env current` and `vp env which` ([#1654](#1654)), by @fengmk2 - vite-task: `--filter` no-match now exits `0` by default; add `--fail-if-no-match` to opt back in ([vite-task#393](voidzero-dev/vite-task#393)), by @kazupon ### Fixes & Enhancements - `vp create`: keep generated `.vscode/settings.json` trackable when the VS Code editor option is selected (avoid templates' `.vscode/*` `.gitignore` masking it) ([#1700](#1700)), by @jong-kyung - `vp create vite:monorepo`: normalize sub-package `vite-plus` to `catalog:` even when only `vite-plus` (not `vite`/`vitest`/...) is present, and drop the `vite`/`vitest` aliases generated by the upstream library template ([#1697](#1697)), by @fengmk2 - `vp add/install -g <path>`: resolve the real package name from `package.json` instead of using the path string, so local-path installs don't create broken directories ([#1685](#1685)), by @liangmiQwQ - `vp test --coverage` and other direct built-in commands now expose the workspace's `package.json#packageManager` to child processes so tools like Vitest coverage can spawn the configured PM ([#1696](#1696)), by @jong-kyung - `vp migrate`: clean up the whole ESLint ecosystem (plugins, configs, parser/resolver, type-utils) rather than just `eslint`; skip the migration entirely when `@nuxt/eslint` is detected ([#1682](#1682)), by @fengmk2 - `vp create`: write `fmt.configPath` (not `configPath`) for Zed oxfmt settings to match the official Zed OXC extension layout ([#1687](#1687)), by @chungweileong94 - `vp migrate`: parse `tsconfig.json` as JSONC so files with comments don't break `baseUrl` detection/removal ([#1688](#1688)), by @TheAlexLichter - `vp env setup`: Unix env shims now point at the active `vp` executable instead of always assuming `VP_HOME/current/bin/vp`, so Homebrew-style installs work ([#1631](#1631)), by @leohara - `vp outdated -g` / `vp why -g`: don't require a local `package.json`; global commands run regardless of cwd ([#1622](#1622)), by @liangmiQwQ - `vp create`: default the "Initialize a git repository?" prompt to yes ([#1650](#1650)), by @fengmk2 - `vp` hooks: include the managed Node bin in `PATH` so `./node_modules/.bin/vp` can find `node` from a VS Code commit on macOS ([#1647](#1647)), by @TheAlexLichter - `vpx` on Windows now invokes the package's `.cmd` shim instead of the Unix binary ([#1652](#1652)), by @tobynguyen27 - vite-task: bump cache database schema to version 13 (forces a one-time rebuild of the local task cache) ([vite-task#402](voidzero-dev/vite-task#402)), by @branchseer - Bump vite-task to `d02b257` and `5833b374`; also bumps the repo's Rust nightly toolchain to `nightly-2026-05-24` and ships the regenerated `run` config types and docs for the new task command shorthand ([#1689](#1689), [#1695](#1695)), by @branchseer ### Refactor - Replace `VP_SHELL_NU`/`VP_SHELL_PWSH` with a single `VP_SHELL` override; add explicit shell parsing for `bash`, `zsh`, `fish`, `nu`, `pwsh`, and `cmd`, and harden auto-detection against nested shells ([#1658](#1658)), by @nekomoyi - vite-task: replace `allocator-api2` with `bumpalo` collections ([vite-task#400](voidzero-dev/vite-task#400)), by @branchseer - vite-task: drop the unused `and_item_index` field from `ExecutionItemDisplay` ([vite-task#394](voidzero-dev/vite-task#394)), by @branchseer ### Docs - Add the root `AGENTS.md` as the primary AI-agent guide for the vite-plus repository; convert `CLAUDE.md` into a compatibility pointer ([#1670](#1670)), by @jong-kyung - Align the agent validation table to match `AGENTS.md` ([#1673](#1673)), by @jong-kyung - Update the task output caching guide so the documented behavior matches what vite-task actually does ([#1639](#1639)), by @ericclemmons - Correct the bundled-source location in `packages/core/BUNDLING.md` ([#1660](#1660)), by @shulaoda ### Chore - Clarify `--help` text for `vp env default`/`pin`/`use`/`exec` with `Examples:` blocks ([#1664](#1664)), by @Boshen - Refresh trusted stack stats on the docs homepage ([#1680](#1680)), by @voidzero-guard[bot] - Drop the standalone `pnpm --filter @rolldown/pluginutils build` step now that `@rolldown/pluginutils` is published from its own package ([#1655](#1655)), by @shulaoda - Preserve single-quote style when `sync-remote` rewrites `pnpm-workspace.yaml` ([#1672](#1672)), by @lyzno1 - Enable `vite_pm_cli` lib tests by removing a stale `test = false` flag ([#1661](#1661)), by @shulaoda - CI: switch macOS runners back to `namespace-profile-mac-default` ([#1701](#1701)), by @fengmk2 - CI: fix release-day flakes in the upgrade test and snap test when the dev `package.json` version equals npm latest ([#1645](#1645)), by @fengmk2 - CI: replace `zizmor` and `cargo-deny` workflows with `oxc-project/security-action` ([#1635](#1635)), by @Boshen - CI: warm-up monorepo cache test under npm ([#1649](#1649)), by @fengmk2 - CI: attach per-target `vp` binary archives (`.tar.gz`/`.zip`) to GitHub Releases alongside the existing `vp-setup-*.exe` installers ([#1665](#1665)), by @Boshen - CI: declare Playwright via `repo.json` in ecosystem tests and bump consumers to `>=1.60` to dodge the Node 24.16.0 hang ([#1668](#1668)), by @fengmk2 - Update GitHub Actions ([#1640](#1640), [#1675](#1675), [#1678](#1678), [#1679](#1679), [#1691](#1691)), by @renovate[bot] - Upgrade upstream dependencies: vite `8.0.11 → 8.0.14`, rolldown `1.0.0 → 1.0.3`, vitest `4.1.6 → 4.1.7`, oxlint `1.63.0 → 1.67.0`, oxfmt `0.48.0 → 0.52.0`, oxlint-tsgolint `0.22.1 → 0.23.0`, `@oxc-project/*` and oxc Rust crates `0.129.0 → 0.133.0` ([#1646](#1646), [#1653](#1653), [#1693](#1693), [#1699](#1699)), by @voidzero-guard[bot] ### Bundled Versions | Tool | Version | Source | | --- | --- | --- | | vite | `8.0.14` | [`c917f1e`](vitejs/vite@c917f1e) | | rolldown | `1.0.3` | [`a287faa`](rolldown/rolldown@a287faa) | | tsdown | `0.22.0` | [npm](https://npmx.dev/package/tsdown/v/0.22.0) | | vitest | `4.1.7` | [npm](https://npmx.dev/package/vitest/v/4.1.7) | | oxlint | `1.67.0` | [npm](https://npmx.dev/package/oxlint/v/1.67.0) | | oxlint-tsgolint | `0.23.0` | [npm](https://npmx.dev/package/oxlint-tsgolint/v/0.23.0) | | oxfmt | `0.52.0` | [npm](https://npmx.dev/package/oxfmt/v/0.52.0) | ### New Contributors Welcome to all new contributors! 🎉 @ericclemmons, @tobynguyen27, @shulaoda, @leohara, @chungweileong94 **Full Changelog**: v0.1.22...v0.1.23 Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: MK <fengmk2@gmail.com>

fix(cli): make env shims use the active vp executable

f4b525c

leohara force-pushed the fix/homebrew-env-shims branch from 9c531d4 to f4b525c Compare May 19, 2026 13:31

leohara mentioned this pull request May 19, 2026

Homebrew installation breaks vp env due to bundled Node.js dependency #1572

Closed

4 tasks

fengmk2 requested a review from nekomoyi May 20, 2026 12:01

fengmk2 self-assigned this May 20, 2026

Merge branch 'main' into fix/homebrew-env-shims

9cf2c63

This comment was marked as off-topic.

Sign in to view

leohara added 2 commits May 20, 2026 23:09

test(cli): fix external vp setup snap

1d90836

Merge remote-tracking branch 'origin/fix/homebrew-env-shims' into fix…

ed328e8

…/homebrew-env-shims

nekomoyi approved these changes May 20, 2026

View reviewed changes

Merge branch 'main' into fix/homebrew-env-shims

5ea4df2

fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests labels May 21, 2026

fengmk2 and others added 4 commits May 21, 2026 13:59

Merge branch 'main' into fix/homebrew-env-shims

793e0b8

test(cli): stabilize external vp snap output

a83e709

Merge branch 'main' of https://github.com/voidzero-dev/vite-plus into…

4fbe50f

… fix/homebrew-env-shims

Merge branch 'main' into fix/homebrew-env-shims

0087e2a

fengmk2 approved these changes May 21, 2026

View reviewed changes

Merge branch 'main' into fix/homebrew-env-shims

5c8e6f2

fengmk2 added 3 commits May 22, 2026 14:41

Merge branch 'main' into fix/homebrew-env-shims

502a3f6

Merge branch 'main' into fix/homebrew-env-shims

121e143

Merge branch 'main' into fix/homebrew-env-shims

7d87192

fengmk2 merged commit de5f8d9 into voidzero-dev:main May 24, 2026
84 of 92 checks passed

fengmk2 mentioned this pull request May 28, 2026

release: v0.1.23 #1703

Merged

BrewTestBot mentioned this pull request May 29, 2026

vite-plus 0.1.23 Homebrew/homebrew-core#285211

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): make env shims use the active vp executable#1631

fix(cli): make env shims use the active vp executable#1631
fengmk2 merged 13 commits into
voidzero-dev:mainfrom
leohara:fix/homebrew-env-shims

leohara commented May 19, 2026

Uh oh!

netlify Bot commented May 19, 2026 •

edited

Loading

Uh oh!

This comment was marked as off-topic.

fengmk2 commented May 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 20, 2026

Uh oh!

fengmk2 left a comment

Uh oh!

fengmk2 commented May 22, 2026

Uh oh!

fengmk2 commented May 22, 2026

Uh oh!

fengmk2 commented May 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

leohara commented May 19, 2026

Summary

Details

Verification

Uh oh!

netlify Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

This comment was marked as off-topic.

fengmk2 commented May 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 20, 2026

Uh oh!

fengmk2 left a comment

Choose a reason for hiding this comment

Uh oh!

fengmk2 commented May 22, 2026

Uh oh!

fengmk2 commented May 22, 2026

Uh oh!

fengmk2 commented May 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented May 19, 2026 •

edited

Loading