refactor: remove unused and_item_index field from ExecutionItemDisplay#394
Merged
Merged
Conversation
The `and_item_index` field on `ExecutionItemDisplay` was only ever written, never read by any reporter or execution code. Remove it and regenerate the plan snapshots. The distinct `and_item_index` on `ExecutionCacheKey::UserTask` is part of the cache key and is unaffected. https://claude.ai/code/session_01LXLpjxLchyX5FyD8Fzmxqp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
and_item_indexfield from theExecutionItemDisplaystruct, which tracked the index of execution items split by&&in task commands. This field was populated during task planning but never used downstream.Changes
and_item_index: Option<usize>field fromExecutionItemDisplayincrates/vite_task_plan/src/lib.rsand_item_indexincrates/vite_task_plan/src/plan.rs(both for split commands and single commands)and_item_indexfield from serialized outputcrates/vite_task/src/session/reporter/mod.rsRationale
The
and_item_indexfield was computed during task planning to indicate which part of a&&-separated command sequence an execution item represented, but this information was never consumed by any downstream code. Removing it simplifies the data structure and reduces unnecessary computation.https://claude.ai/code/session_01LXLpjxLchyX5FyD8Fzmxqp