Skip to content

refactor: pack and gather patches with explicit chunk widths - #9941

Draft
mhk197 wants to merge 1 commit into
mk/bitpacked-stack-04-offset-childfrom
mk/bitpacked-stack-05-explicit-packing
Draft

mhk197 wants to merge 1 commit into
mk/bitpacked-stack-04-offset-childfrom
mk/bitpacked-stack-05-explicit-packing

Conversation

@mhk197

@mhk197 mhk197 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Share packing and exception gathering between uniform and explicit per-chunk layouts. Expose an encoder for caller-supplied chunk widths, including full-width and zero-width chunks, while retaining the global-width entry points. Cover full-width chunks and zero-copy slicing with nonzero offset origins.

Part 5/9 of the bitpacked-v2 stack (545 added + removed lines). Merge in order; each draft targets the preceding branch, starting from develop.

123456789

Validation: All 13 focused plugin, serde, and chunk-layout tests passed on this commit, including the regression that rejects direct vtable serde. Changed Rust files were formatted with nightly; git diff --check passed.

@codspeed

codspeed Bot commented Sep 18, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.65%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 5 regressed benchmarks
✅ 2247 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decode_primitives[f32, (1000, 512)] 42 µs 64.3 µs -34.67%
Simulation random_i8[0.5] 72.4 µs 96 µs -24.6%
Simulation bitpacked_compress_u32 49.6 µs 60.7 µs -18.29%
WallTime words_gather_scalar_avx2[65536] 8.3 µs 9.4 µs -11.8%
WallTime mul_u32_nonnull_avx512 5.6 µs 6.3 µs -11.01%
Simulation random_i16[0.95] 99.7 µs 81.5 µs +22.34%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/bitpacked-stack-05-explicit-packing (120d3bd) with mk/bitpacked-stack-04-offset-child (cfa9850)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: "Matt Katz" <mhkatz97@gmail.com>
@mhk197
mhk197 force-pushed the mk/bitpacked-stack-05-explicit-packing branch from e1be4ab to 120d3bd Compare September 18, 2026 19:42
@mhk197
mhk197 deployed to duckdb-build September 18, 2026 19:42 — with GitHub Actions Active
@mhk197
mhk197 deployed to duckdb-build September 18, 2026 19:42 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant