feat(webpack-cli): add no-hot flag

packages/webpack-cli/README.md

@@ -48,6 +48,7 @@ Options
   -t, --target string      Sets the build target
   -w, --watch              Watch for files changes
   -h, --hot                Enables Hot Module Replacement
+  --no-hot                 Disables Hot Module Replacement
   -s, --sourcemap string   Determine source maps to use
   --prefetch string        Prefetch this request
   -j, --json               Prints result as JSON

packages/webpack-cli/__tests__/AdvancedGroup.test.js

@@ -0,0 +1,14 @@
+const AdvancedGroup = require('../lib/groups/AdvancedGroup');
+
+describe('GroupHelper', function() {
+    it('should load the hot advanced config', () => {
+        const group = new AdvancedGroup([
+            {
+                hot: true,
+            },
+        ]);
+
+        const result = group.run();
+        expect(result.options.plugins).toBeTruthy();
+    });
+});

packages/webpack-cli/lib/groups/AdvancedGroup.js

@@ -57,6 +57,12 @@ class AdvancedGroup extends GroupHelper {
                 options.plugins = [hotModuleVal];
             }
         }
+        if (args.noHot && args.hot) {
+            logger.warn('You provided both --hot and --no-hot. You should provide just one, "--hot" will be used')
+        }
+        if (args.noHot){
+            args.hot = false;
+        }
         if (args.prefetch) {
             const { PrefetchPlugin } = require('webpack');
             const prefetchVal = new PrefetchPlugin(null, args.prefetch);

packages/webpack-cli/lib/utils/cli-flags.js

@@ -232,6 +232,14 @@ module.exports = {
             description: 'Enables Hot Module Replacement',
             link: 'https://webpack.js.org/concepts/hot-module-replacement/',
         },
+        {
+            name: 'no-hot',
+            usage: 'webpack --no-hot',
+            type: Boolean,
+            group: ADVANCED_GROUP,
+            description: 'Disables Hot Module Replacement',
+            link: 'https://webpack.js.org/concepts/hot-module-replacement/',
+        },
         {
             name: 'sourcemap',
             usage: '--sourcemap <sourcemap|eval|>',

test/no-hot/no-hot.test.js

@@ -0,0 +1,28 @@
+'use strict';
+const { run } = require('../utils/test-utils');
+const { stat } = require('fs');
+const { resolve } = require('path');
+describe('no-hot flag', () => {
+    it('should be successful when --no-hot is passed', done => {
+        const { stderr, stdout } = run(__dirname, ['--no-hot']);
+        expect(stderr).toBeFalsy();
+        expect(stdout).toBeTruthy();
+        stat(resolve(__dirname, './bin/main.js'), (err, stats) => {
+            expect(err).toBe(null);
+            expect(stats.isFile()).toBe(true);
+            done();
+        });
+    });
+
+    it('should use --hot when --hot and --no-hot are passed', done => {
+        const { stderr, stdout } = run(__dirname, ['--no-hot', '--hot']);
+        expect(stderr).toContain('"--hot" will be used');
+        expect(stdout).toBeTruthy();
+
+        stat(resolve(__dirname, './bin/main.js'), (err, stats) => {
+            expect(err).toBe(null);
+            expect(stats.isFile()).toBe(true);
+            done();
+        });
+    });
+});

test/no-hot/src/index.js

@@ -0,0 +1 @@
+console.log('HELLO WORLD') ;

test/no-hot/test-with-config/index.js

@@ -0,0 +1 @@
+console.log('TEST WITH CONFIG');

test/no-hot/test-with-config/no-hot-with-config.test.js

@@ -0,0 +1,16 @@
+'use strict';
+const { run } = require('../../utils/test-utils');
+const { stat } = require('fs');
+const { resolve } = require('path');
+describe('no-hot flag', () => {
+    it('should be successful when --no-hot is passed', done => {
+        const { stderr, stdout } = run(__dirname, ['--no-hot']);
+        expect(stderr).toBeFalsy();
+        expect(stdout).toBeTruthy();
+        stat(resolve(__dirname, './bin/main.js'), (err, stats) => {
+            expect(err).toBe(null);
+            expect(stats.isFile()).toBe(true);
+            done();
+        });
+    });
+});

test/no-hot/test-with-config/webpack.config.js

@@ -0,0 +1,7 @@
+module.exports = {
+    mode: 'development',
+    entry: './index.js',
+    devServer: {
+        hot: true,
+    },
+};

test/no-hot/webpack.config.js

@@ -0,0 +1,4 @@
+module.exports = {
+    mode: 'development',
+    entry: './src/index.js',
+};

test/serve/serve-basic.test.js

@@ -30,6 +30,12 @@ describe('basic serve usage', () => {
         expect(stderr).toHaveLength(0);
     });
 
+    it('uses no-hot flag', async () => {
+        const { stdout, stderr } = await runServe(['--no-hot']);
+        expect(stdout).toContain('main.js');
+        expect(stderr).toHaveLength(0);
+    });
+
     it('uses hot flag and progress flag', async () => {
         const { stdout, stderr } = await runServe(['--hot', '--progress']);
         expect(stdout).toContain('main.js');