feat(webpack-cli): add no-hot flag#1296
Closed
snitin315 wants to merge 1 commit into
Closed
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
suggested changes
Mar 6, 2020
ematipico
left a comment
ematipico
left a comment
Contributor
There was a problem hiding this comment.
Good work I think. We should cover more cases with tests
webpack-bot
added
PR: reviewed-changes-requested
PR: review-outdated
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
ematipico
suggested changes
Mar 9, 2020
ematipico
left a comment
ematipico
left a comment
Contributor
There was a problem hiding this comment.
Please create the following tests:
- with a configuration file where there's
devServer: { hot: true } - a test for the serve command (webpack-dev-server consumes the flag)
This comment has been minimized.
This comment has been minimized.
snitin315
requested review from
jamesgeorge007
and removed request for
ematipico
March 18, 2020 14:06
alexander-akait
requested changes
Mar 18, 2020
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
We should suspend this work until we merge #1347
webpack-bot
added
PR: reviewed-changes-requested
PR: CI-ok
and removed
PR: review-outdated
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added
--no-hotflag to CLI.Did you add tests for your changes?
YES
If relevant, did you update the documentation?
YES
Summary
Refers #1240
Refers #1012
Does this PR introduce a breaking change?
NO
Other information